linux-kernel - RE: [PATCH v3] scsi: ufs: Zero utp_upiu_req at the beginning of each command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DM6PR04MB6575F21241AD2B765375B715FC6C2@DM6PR04MB6575.namprd04.prod.outlook.com>
Date: Fri, 20 Sep 2024 19:01:07 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] scsi: ufs: Zero utp_upiu_req at the beginning of each
 command

> On 9/19/24 1:41 AM, Avri Altman wrote:
> > +static void __ufshcd_setup_cmd(struct ufs_hba *hba, struct ufshcd_lrb
> *lrbp,
> > +                          struct scsi_cmnd *cmd, u8 lun, int tag) {
> > +     memset(lrbp->ucd_req_ptr, 0, sizeof(*lrbp->ucd_req_ptr));
> > +
> > +     lrbp->cmd = cmd;
> > +     lrbp->task_tag = tag;
> > +     lrbp->lun = lun;
> > +     ufshcd_prepare_lrbp_crypto(cmd ? scsi_cmd_to_rq(cmd) : NULL,
> > +lrbp); }
> 
> This function does not use the 'hba' argument so please remove that
> argument. Otherwise this patch looks good to me.
Done.

Thanks,
Avri
> 
> Thanks,
> 
> Bart.