linux-kernel - Re: [PATCH 1/2 v2] PCI/portdrv: Enable reporting inter-switch P2P links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202409201219.feYAxGor-lkp@intel.com>
Date: Fri, 20 Sep 2024 12:28:56 +0800
From: kernel test robot <lkp@...el.com>
To: Shivasharan S <shivasharan.srikanteshwara@...adcom.com>,
	linux-pci@...r.kernel.org, bhelgaas@...gle.com,
	manivannan.sadhasivam@...aro.org, logang@...tatee.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org, sumanesh.samanta@...adcom.com,
	sathya.prakash@...adcom.com, sjeaugey@...dia.com,
	Shivasharan S <shivasharan.srikanteshwara@...adcom.com>
Subject: Re: [PATCH 1/2 v2] PCI/portdrv: Enable reporting inter-switch P2P
 links

Hi Shivasharan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on next-20240919]
[cannot apply to pci/for-linus linus/master v6.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shivasharan-S/PCI-portdrv-Enable-reporting-inter-switch-P2P-links/20240919-162626
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/1726733624-2142-2-git-send-email-shivasharan.srikanteshwara%40broadcom.com
patch subject: [PATCH 1/2 v2] PCI/portdrv: Enable reporting inter-switch P2P links
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20240920/202409201219.feYAxGor-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240920/202409201219.feYAxGor-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409201219.feYAxGor-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pci/pcie/portdrv.c:86: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Determine if device supports Inter switch P2P links.


vim +86 drivers/pci/pcie/portdrv.c

    84	
    85	/**
  > 86	 * Determine if device supports Inter switch P2P links.
    87	 *
    88	 * Return value: true if inter switch P2P is supported, return false otherwise.
    89	 */
    90	static bool pcie_port_is_p2p_supported(struct pci_dev *dev)
    91	{
    92		/* P2P link attribute is supported on upstream ports only */
    93		if (pci_pcie_type(dev) != PCI_EXP_TYPE_UPSTREAM)
    94			return false;
    95	
    96		/*
    97		 * Currently Broadcom PEX switches are supported.
    98		 */
    99		if (dev->vendor == PCI_VENDOR_ID_LSI_LOGIC &&
   100		    (dev->device == PCI_DEVICE_ID_BRCM_PEX_89000_HLC ||
   101		     dev->device == PCI_DEVICE_ID_BRCM_PEX_89000_LLC))
   102			return pcie_brcm_is_p2p_supported(dev);
   103	
   104		return false;
   105	}
   106	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki