linux-kernel - Re: [PATCH 1/2] tools/leds: Add '-h' & '--help' cmd line options to uledmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <102418ed-c7c3-3287-7ad0-f7a48b600c18@gmail.com>
Date: Fri, 20 Sep 2024 23:01:43 +0200
From: Jacek Anaszewski <jacek.anaszewski@...il.com>
To: Rajkumar Vadhyar <rajkumarvad@...il.com>
Cc: "Ricardo B. Marliere" <rbmarliere@...il.com>,
 Shuah Khan <skhan@...uxfoundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] tools/leds: Add '-h' & '--help' cmd line options to
 uledmon

Hi Rajkumar,

LED maintainers are responsible also for tools/leds.
MAINTAINERS file say today the following:

LED SUBSYSTEM
M:  Pavel Machek <pavel@....cz>
M:  Lee Jones <lee@...nel.org>

-- 
Best regards,
Jacek Anaszewski

On 8/26/24 05:58, Rajkumar Vadhyar wrote:
> Hi Jacek,
> Actually when I did getmaintainer.pl <http://getmaintainer.pl> on the 
> patch I was only getting the mailing list email id. Also when I did git 
> blame I saw your name as the committer of the led file so I thought you 
> might be the maintainer also.
> Would you know who is the maintainer of this tools/leds? Thank you
> 
> Regards,
> Rajkumar
> 
> On Sun, 25 Aug 2024, 17:25 Jacek Anaszewski, <jacek.anaszewski@...il.com 
> <mailto:jacek.anaszewski@...il.com>> wrote:
> 
>     https://www.royalmail.com/track-your-item#/tracking-results/LE879811818GB
> 
>     You should send it to linux-leds@...r.kernel.org
>     <mailto:linux-leds@...r.kernel.org> and to LEDs maintainer.
> 
>     -- 
>     Best regards,
>     Jacek Anaszewski
> 
>     On 8/20/24 09:23, Rajkumar Vadhyar wrote:
>      > Add '-h' and '--help' command line options to uledmon
>      >
>      > Signed-off-by: Rajkumar Vadhyar <rajkumarvad@...il.com
>     <mailto:rajkumarvad@...il.com>>
>      > ---
>      >   tools/leds/uledmon.c | 7 +++++++
>      >   1 file changed, 7 insertions(+)
>      >
>      > diff --git a/tools/leds/uledmon.c b/tools/leds/uledmon.c
>      > index c15a39c1f271..6609235d80b0 100644
>      > --- a/tools/leds/uledmon.c
>      > +++ b/tools/leds/uledmon.c
>      > @@ -11,6 +11,8 @@
>      >    * CTRL+C will exit.
>      >    */
>      >
>      > +#define      ULEDMON_USAGE   "Usage: ./uledmon <device-name>\n"
>      > +
>      >   #include <fcntl.h>
>      >   #include <stdio.h>
>      >   #include <string.h>
>      > @@ -19,6 +21,7 @@
>      >
>      >   #include <linux/uleds.h>
>      >
>      > +
>      >   int main(int argc, char const *argv[])
>      >   {
>      >       struct uleds_user_dev uleds_dev;
>      > @@ -30,6 +33,10 @@ int main(int argc, char const *argv[])
>      >               fprintf(stderr, "Requires <device-name> argument\n");
>      >               return 1;
>      >       }
>      > +     if (!(strcmp(argv[1], "-h")) || !(strcmp(argv[1], "--help"))) {
>      > +             fprintf(stderr, ULEDMON_USAGE);
>      > +             return 1;
>      > +     }
>      >
>      >       strncpy(uleds_dev.name <http://uleds_dev.name>, argv[1],
>     LED_MAX_NAME_SIZE);
>      >       uleds_dev.max_brightness = 100;
>