[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <y6a347udrtudmbfsq7erk7m3dt5smasqg3mffaazwl67zua75d@sl57aj6rwa3g>
Date: Sat, 21 Sep 2024 04:01:34 +0530
From: Abdul Rahim <abdul.rahim@...ahoo.com>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: perex@...ex.cz, tiwai@...e.com, broonie@...nel.org, shuah@...nel.org,
linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kselftest/alsa: add silent flag to reduce noise
On Fri, Sep 20, 2024 at 09:27:03AM -0600, Shuah Khan wrote:
> On 9/19/24 15:49, Abdul Rahim wrote:
> > On Thu, Sep 19, 2024 at 09:40:34AM GMT, Shuah Khan wrote:
> > > On 9/15/24 17:41, Abdul Rahim wrote:
> > > > When ALSA is not installed on the users system, the error:
> > > >
> > > > "Package alsa was not found in the pkg-config search path.
> > > > Perhaps you should add the directory containing `alsa.pc'
> > > > to the PKG_CONFIG_PATH environment variable
> > > > Package 'alsa', required by 'virtual:world', not found"
> > > >
> > >
> > > extra line?
> > >
> > > > is printed 3 times, which generates unnecessary noise.
> > > > Hence, Remove unnecessary noise using `--silence-errors` on LDLIBS
> > > > assignment, so the message is printed only once.
> > >
> > > I would say this message is alerting the user that the package is missing.
> > > Why would you want to delete it?
> > >
> > > >
> > > > Signed-off-by: Abdul Rahim <abdul.rahim@...ahoo.com>
> > > > ---
> > > > tools/testing/selftests/alsa/Makefile | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/tools/testing/selftests/alsa/Makefile b/tools/testing/selftests/alsa/Makefile
> > > > index 25be68025290..cd022fc869fb 100644
> > > > --- a/tools/testing/selftests/alsa/Makefile
> > > > +++ b/tools/testing/selftests/alsa/Makefile
> > > > @@ -2,7 +2,7 @@
> > > > #
> > > > CFLAGS += $(shell pkg-config --cflags alsa) $(KHDR_INCLUDES)
> > > > -LDLIBS += $(shell pkg-config --libs alsa)
> > > > +LDLIBS += $(shell pkg-config --silence-errors --libs alsa)
> > > > ifeq ($(LDLIBS),)
> > > > LDLIBS += -lasound
> > > > endif
> > >
> > >
> > > thanks,
> > > -- Shuah
> > >
> >
> > This can also be handled like this:
> > ---
> > CHECK := $(shell pkg-config --exists alsa; echo $?)
> > ifneq ($(CHECK),0)
> > $(error Package alsa not found! Add directory containing alsa.pc in PKG_CONFIG_PATH)
> > endif
> > ---
> >
>
> This is a better solution than suppressing errors.
>
> thanks,
> -- Shuah
>
Yes, i see. Because other errors can also be silenced.
I'll resend this one
Thanks mam
Powered by blists - more mailing lists