linux-kernel - Re: [PATCH] staging: sm750fb: Rename variable sm750_hw_cursor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf02d1e2-c912-4e43-9396-7e056d1b92ef@lkcamp.dev>
Date: Sat, 21 Sep 2024 12:38:35 -0300
From: Vinicius Peixoto <vpeixoto@...amp.dev>
To: Fabricio Gasperin <fgasperin@...amp.dev>,
 Sudip Mukherjee <sudipm.mukherjee@...il.com>,
 Teddy Wang <teddy.wang@...iconmotion.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org, ~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH] staging: sm750fb: Rename variable
 sm750_hw_cursor_setData2

Hi Fabricio,

On 9/21/24 12:21, Fabricio Gasperin wrote:
> Rename function sm750_hw_cursor_setData2 to sm_750_hw_cursor_setdata2
> 
> Change made in order to silence the camelCase warning from checkpatch.pl
> 
> Signed-off-by: Fabricio Gasperin <fgasperin@...amp.dev>
> ---
>   drivers/staging/sm750fb/sm750_cursor.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
> index eea4d1bd36ce..e95f39b51a2f 100644
> --- a/drivers/staging/sm750fb/sm750_cursor.c
> +++ b/drivers/staging/sm750fb/sm750_cursor.c
> @@ -131,7 +131,7 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop,
>   	}
>   }
>   
> -void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop,
> +void sm750_hw_cursor_setdata2(struct lynx_cursor *cursor, u16 rop,
>   			      const u8 *pcol, const u8 *pmsk)
I think you missed one other occurrence of this function in the header 
(drivers/staging/sm750fb/sm750_cursor.h), which causes it to fail to 
build. Please fix the function name there as well. I think those are the 
only two occurrences of it, though.

>   {
>   	int i, j, count, pitch, offset;

Thanks,
Vinicius