[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJppc7jUfVx7Fw=tBjWGdp7ULb2pbK9x-re+1bNq2kxMR4A@mail.gmail.com>
Date: Sat, 21 Sep 2024 20:52:22 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Mahadevan <quic_mahap@...cinc.com>, robdclark@...il.com, quic_abhinavk@...cinc.com,
sean@...rly.run, marijn.suijten@...ainline.org, airlied@...il.com,
daniel@...ll.ch, maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
tzimmermann@...e.de, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
swboyd@...omium.org, konrad.dybcio@...aro.org, danila@...xyga.com,
bigfoot@...ssfun.cn, neil.armstrong@...aro.org, mailingradian@...il.com,
quic_jesszhan@...cinc.com, andersson@...nel.org,
linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, quic_kalyant@...cinc.com,
quic_jmadiset@...cinc.com, quic_vpolimer@...cinc.com
Subject: Re: [PATCH 1/5] dt-bindings: display/msm: Document MDSS on SA8775P
On Sat, 21 Sept 2024 at 20:23, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 12/09/2024 09:14, Mahadevan wrote:
> >
> > + clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
> > + <&gcc GCC_DISP_HF_AXI_CLK>,
> > + <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>;
> > +
> > + interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-controller;
> > + #interrupt-cells = <1>;
> > +
> > + iommus = <&apps_smmu 0x1000 0x402>;
> > +
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > +
> > + status = "disabled";
>
> Uh no, it cannot be disabled. What would be the point of it? Please
> reach to your colleagues for some internal review before posting (see
> also go/upstream in internal systems).
Rob, can we make it part of dt-validate maybe? Error out if schema
_examples_ have disabled nodes.
--
With best wishes
Dmitry
Powered by blists - more mailing lists