linux-kernel - Re: [PATCH v1 0/2] iio: core: remove iio_validate_own

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd1df0c5-d95f-4880-b374-a7544a323d93@metafoo.de>
Date: Sat, 21 Sep 2024 12:23:39 -0700
From: Lars-Peter Clausen <lars@...afoo.de>
To: Vasileios Amoiridis <vassilisamir@...il.com>, jic23@...nel.org,
 mazziesaccount@...il.com
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/2] iio: core: remove iio_validate_own_trigger()
 function

On 9/21/24 11:19, Vasileios Amoiridis wrote:
> The iio_validate_own_trigger() function was added in this commit [1] but it is
> the same with the below function called iio_trigger_validate_own_device(). The
> bodies of the functions can be found in [2], [3].
>
> [1]: https://lore.kernel.org/all/51cd3e3e74a6addf8d333f4a109fb9c5a11086ee.1683541225.git.mazziesaccount@gmail.com/
> [2]: https://elixir.bootlin.com/linux/v6.11/source/drivers/iio/industrialio-trigger.c#L732
> [3]: https://elixir.bootlin.com/linux/v6.11/source/drivers/iio/industrialio-trigger.c#L752

The signature of the two functions are different, the order of the 
parameters is switched. So you can't just swap them out for the 
`validate_trigger` callback since the signature is not compatible. But 
maybe you can update the implementation of one of the functions to 
calling the other function.