linux-kernel - Re: drivers/spmi/spmi-pmic-arb.c:1782 spmi_pmic_arb_register_buses() error: uninitialized symbol 'ret'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cae4d71b611c36dab4003fa4ec3bab61.sboyd@kernel.org>
Date: Sat, 21 Sep 2024 12:54:10 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Abel Vesa <abel.vesa@...aro.org>, Dan Carpenter <dan.carpenter@...aro.org>, Neil Armstrong <neil.armstrong@...aro.org>, oe-kbuild@...ts.linux.dev
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: drivers/spmi/spmi-pmic-arb.c:1782 spmi_pmic_arb_register_buses() error: uninitialized symbol 'ret'.

Quoting Neil Armstrong (2024-09-18 03:34:22)
> On 18/09/2024 12:29, Dan Carpenter wrote:
> > 9799873717398e8 Abel Vesa 2024-05-07  1767    struct device_node *child;
> > 9799873717398e8 Abel Vesa 2024-05-07  1768    int ret;
> > 9799873717398e8 Abel Vesa 2024-05-07  1769
> > 9799873717398e8 Abel Vesa 2024-05-07  1770    /* legacy mode doesn't provide child node for the bus */
> > 9799873717398e8 Abel Vesa 2024-05-07  1771    if (of_device_is_compatible(node, "qcom,spmi-pmic-arb"))
> > 9799873717398e8 Abel Vesa 2024-05-07  1772            return spmi_pmic_arb_bus_init(pdev, node, pmic_arb);
> > 9799873717398e8 Abel Vesa 2024-05-07  1773
> > 9799873717398e8 Abel Vesa 2024-05-07  1774    for_each_available_child_of_node(node, child) {
> > 9799873717398e8 Abel Vesa 2024-05-07  1775            if (of_node_name_eq(child, "spmi")) {
> > 9799873717398e8 Abel Vesa 2024-05-07  1776                    ret = spmi_pmic_arb_bus_init(pdev, child, pmic_arb);
> > 9799873717398e8 Abel Vesa 2024-05-07  1777                    if (ret)
> > 9799873717398e8 Abel Vesa 2024-05-07  1778                            return ret;
> > 9799873717398e8 Abel Vesa 2024-05-07  1779            }
> > 9799873717398e8 Abel Vesa 2024-05-07  1780    }
> > 9799873717398e8 Abel Vesa 2024-05-07  1781
> > 9799873717398e8 Abel Vesa 2024-05-07 @1782    return ret;
> > 
> > Is it possible to not have an spmi node?
> 
> It's possible but not allowed per the bindings.
> 

Seems that we should just return 0 here then and squelch the warning.