linux-kernel - Re: [PATCH] powerpc/vdso32: Fix use of crtsavres for PPC64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <A9FC02B9-A15D-4A75-872F-BC85248A1BBB@xenosoft.de>
Date: Sat, 21 Sep 2024 09:46:54 +0200
From: Christian Zigotzky <chzigotzky@...osoft.de>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Jason A Donenfeld <Jason@...c4.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>, linux-kernel@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org, Trevor Dickinson <rtd2@...a.co.nz>,
 mad skateman <madskateman@...il.com>,
 Darren Stevens <darren@...vens-zone.net>
Subject: Re: [PATCH] powerpc/vdso32: Fix use of crtsavres for PPC64

On 19. Sep 2024, at 20:56, Christophe Leroy <christophe.leroy@...roup.eu> wrote:

crtsavres.S content is encloded by a #ifndef CONFIG_PPC64

To be used on VDSO32 on PPC64 it's content must available on PPC64 as
well.

Replace #ifndef CONFIG_PPC64 by #ifndef __powerpc64__ as __powerpc64__
is not set when building VDSO32 on PPC64.

Reported-by: Christian Zigotzky <chzigotzky@...osoft.de>
Closed: https://lore.kernel.org/linuxppc-dev/047b7503-af0c-4bb0-b12a-2f6b1e461752@csgroup.eu/T/
Fixes: b163596a5b6f ("powerpc/vdso32: Add crtsavres")
Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
---
arch/powerpc/lib/crtsavres.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/lib/crtsavres.S b/arch/powerpc/lib/crtsavres.S
index 7e5e1c28e56a..8967903c15e9 100644
--- a/arch/powerpc/lib/crtsavres.S
+++ b/arch/powerpc/lib/crtsavres.S
@@ -46,7 +46,7 @@

   .section ".text"

-#ifndef CONFIG_PPC64
+#ifndef __powerpc64__

/* Routines for saving integer registers, called by the compiler.  */
/* Called with r11 pointing to the stack header word of the caller of the */
--
2.44.0


It works! Thank you.

Tested-by: Christian Zigotzky <chzigotzky@...osoft.de>