linux-kernel - Re: [PATCH] mm/damon: fix sparse warning for zero initializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240922151121.469051-1-sj@kernel.org>
Date: Sun, 22 Sep 2024 08:11:20 -0700
From: SeongJae Park <sj@...nel.org>
To: Leo Stone <leocstone@...il.com>
Cc: SeongJae Park <sj@...nel.org>,
	akpm@...ux-foundation.org,
	ruanjinjie@...wei.com,
	damon@...ts.linux.dev,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linuxfoundation.org,
	skhan@...uxfoundation.org
Subject: Re: [PATCH] mm/damon: fix sparse warning for zero initializer

Hi Leo,


Thank you for this patch!

On Sat, 21 Sep 2024 12:54:45 -0700 Leo Stone <leocstone@...il.com> wrote:

> sparse warns about zero initializing an array with {0,}, change it to
> the equivalent {0}.
> 
> Fixes the sparse warning:
> mm/damon/tests/vaddr-kunit.h:69:47: warning: missing braces around initializer
> 
> Signed-off-by: Leo Stone <leocstone@...il.com>

Reviewed-by: SeongJae Park <sj@...nel.org>

I also think below tag would be good to add?

17ccae8bb5c9 ("mm/damon: add kunit tests")

Thanks,
SJ

> ---
>  mm/damon/tests/vaddr-kunit.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h
> index a339d117150f..3dad8dfd9005 100644
> --- a/mm/damon/tests/vaddr-kunit.h
> +++ b/mm/damon/tests/vaddr-kunit.h
> @@ -66,7 +66,7 @@ static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas,
>  static void damon_test_three_regions_in_vmas(struct kunit *test)
>  {
>  	static struct mm_struct mm;
> -	struct damon_addr_range regions[3] = {0,};
> +	struct damon_addr_range regions[3] = {0};
>  	/* 10-20-25, 200-210-220, 300-305, 307-330 */
>  	struct vm_area_struct vmas[] = {
>  		(struct vm_area_struct) {.vm_start = 10, .vm_end = 20},
> -- 
> 2.43.0