linux-kernel - Re: [PATCH] net: fjes: Refactor a string comparison in is_extended_socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240922170811.GE3426578@kernel.org>
Date: Sun, 22 Sep 2024 18:08:11 +0100
From: Simon Horman <horms@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: netdev@...r.kernel.org, Christian Marangi <ansuelsmth@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Nick Child <nnac123@...ux.ibm.com>, Paolo Abeni <pabeni@...hat.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Taku Izumi <izumi.taku@...fujitsu.com>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Julia Lawall <julia.lawall@...ia.fr>,
	Yasuaki Ishimatsu <yasu.isimatu@...il.com>
Subject: Re: [PATCH] net: fjes: Refactor a string comparison in
 is_extended_socket_device()

On Fri, Sep 20, 2024 at 02:24:50PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 20 Sep 2024 13:56:44 +0200
> 
> Assign the return value from a strncmp() call to a local variable
> so that an if statement can be omitted accordingly.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Hi Markus,

This is an old driver, that doesn't appear to have been under active
development for quite some time.  And I don't think that clean-ups of this
nature are worth the risk of regressions they might introduce.

If we can see bugs, let's fix them.
Else, let's leave it be.

-- 
pw-bot: rejected