linux-kernel - Re: [PATCH] dt-bindings: usb: add missing compatible arraylist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86595df6-6048-499e-8ac2-d63fbb0c7b9f@kernel.org>
Date: Sun, 22 Sep 2024 20:51:30 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Karan Sanghavi <karansanghvi98@...il.com>,
 Roger Quadros <rogerq@...nel.org>, Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: add missing compatible arraylist

On 22/09/2024 19:00, Karan Sanghavi wrote:
> Added the vice versa order for compatible property in the yaml file so
> that the dtb can parse for the order mentioned in the dts file
> k3-am642-sk.dts for ti,j721e-usb.yaml
> 
> This is highly ambiguous to me as where exactly the changes needs to be
> added is it in the dts file or is the yaml where we have to reverse the
> order already mentioned or do we have to add the another order as I have
> done ?

If you do not understand the problem being fixed thus not know how to
fix it, I don't quite get why you decided to send a patch...

> 
> Signed-off-by: Karan Sanghavi <karansanghvi98@...il.com>
> ---
>  Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> index 95ff9791baea..822653217c43 100644
> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> @@ -17,6 +17,9 @@ properties:
>        - items:
>            - const: ti,j721e-usb
>            - const: ti,am64-usb
> +      - items:
> +          - const: ti,am64-usb
> +          - const: ti,j721e-usb

Sorry, this does not look right - duplicates above compatibles. Nothing
in the commit msg explains why this order is needed (in terms of hardware).

Best regards,
Krzysztof