linux-kernel - Re: [PATCH 0/2] staging: rtl8192e: Use MSR_LINK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bb46e16-eb37-4d76-a917-e0f1e738fd04@gmail.com>
Date: Sun, 22 Sep 2024 21:01:09 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Dominik Karol Piątkowski
 <dominik.karol.piatkowski@...tonmail.com>, gregkh@...uxfoundation.org,
 tdavies@...kphysics.net, dan.carpenter@...aro.org
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] staging: rtl8192e: Use MSR_LINK_* macros

On 9/21/24 2:22 PM, Dominik Karol Piątkowski wrote:
> There were two seemingly not used macros defined in r8192E_hw.h:
> MSR_LINK_ADHOC and MSR_LINK_MASTER.
> 
> There is one function explicitly updating MSR (Media Status Register):
> _rtl92e_update_msr - only MSR_LINK_MASK and MSR_LINK_MANAGED are used
> there. However, in rtl92e_set_reg, inside HW_VAR_MEDIA_STATUS section,
> MSR is also updated - covering more than MSR_LINK_MANAGED case.
> 
> This series makes use of appropriate MSR_LINK_* macros in rtl92e_set_reg
> and removes duplicated MSR_* macros. While at it, fix camel case variable
> in rtl92e_set_reg function.
> 
> Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@...tonmail.com>
> 
> Dominik Karol Piątkowski (2):
>    staging: rtl8192e: Use MSR_LINK_* macros
>    staging: rtl8192e: r8192E_dev.c: Rename btMsr variable
> 
>   drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 14 +++++++-------
>   drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h  |  6 +-----
>   2 files changed, 8 insertions(+), 12 deletions(-)
> 

Reviewed-by: Philipp Hortmann <philipp.g.hortmann@...il.com>