linux-kernel - Re: [PATCH] Staging: net/ethernet/broadcom: Add error pointer check in bcmsysport.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13fbb6c3-661f-477a-b33b-99303cd11622@lunn.ch>
Date: Sun, 22 Sep 2024 22:08:58 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Dipendra Khadka <kdipendra88@...il.com>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: net/ethernet/broadcom: Add error pointer check
 in bcmsysport.c

On Sun, Sep 22, 2024 at 06:17:37PM +0000, Dipendra Khadka wrote:
> Smatch reported following:
> '''
> drivers/net/ethernet/broadcom/bcmsysport.c:2343 bcm_sysport_map_queues() error: 'dp' dereferencing possible ERR_PTR()
> drivers/net/ethernet/broadcom/bcmsysport.c:2395 bcm_sysport_unmap_queues() error: 'dp' dereferencing possible ERR_PTR()
> '''
> 
> Adding error pointer check before dereferencing 'dp'.

This driver is not in staging, so your subject is wrong.

Please take a look at:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

    Andrew

---
pw-bot: cr