[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a90d08d5-265a-4ba2-99f9-68fa18960b27@redhat.com>
Date: Sun, 22 Sep 2024 13:11:46 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
tjakobi@...h.uni-bielefeld.de
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Joaquín Ignacio Aramendía <samsagax@...il.com>,
"Derek J . Clark" <derekjohn.clark@...il.com>,
Denis Benato <benato.denis96@...il.com>, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] drm: panel-orientation-quirks: Add quirk for AYA NEO
2 model
Hi,
On 21-Sep-24 10:02 PM, Dmitry Baryshkov wrote:
> On Mon, Sep 16, 2024 at 03:18:51PM GMT, tjakobi@...h.uni-bielefeld.de wrote:
>> From: Joaquín Ignacio Aramendía <samsagax@...il.com>
>>
>> Add quirk orientation for AYA NEO 2. The name appears without spaces in
>> DMI strings. That made it difficult to reuse the 2021 match. Also the
>> display is larger in resolution.
>>
>> Tested by the JELOS team that has been patching their own kernel for a
>> while now and confirmed by users in the AYA NEO and ChimeraOS discord
>> servers.
>>
>> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@...il.com>
>> Signed-off-by: Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>
>> ---
>> drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> index 2166208a961d..3044927c0c5c 100644
>> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> @@ -184,6 +184,12 @@ static const struct dmi_system_id orientation_data[] = {
>> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"),
>> },
>> .driver_data = (void *)&lcd800x1280_rightside_up,
>> + }, { /* AYA NEO AYANEO 2 */
>> + .matches = {
>> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
>> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYANEO 2"),
>> + },
>> + .driver_data = (void *)&lcd1200x1920_rightside_up,
>
> I thought that AYANEO should come after AYADEVICE, but the array doesn't
> seem really sorted
It is sorted but it is sorted by the Vendor - Model in the comments,
not by the DMI strings since sometimes those are e.g. "SYS_VENDOR",
"Default String" and stuff like that.
The entire series looks good to me:
Reviewed-by: Hans de Goede <hdegoede@...hat.com>
for the series.
> Thus:
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>
> If I hear no objections and if noone beats me, I'll apply the series
> within few days.
I'm currently travelling so if you can apply this series
to drm-misc-fixes that would be great.
Regards,
Hans
>
>
>> }, { /* AYA NEO 2021 */
>> .matches = {
>> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYADEVICE"),
>> --
>> 2.44.2
>>
>
Powered by blists - more mailing lists