linux-kernel - Re: [PATCH v4 4/4] media: platform: synopsys: Add support for hdmi input driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8239ae11-12a7-49fd-b78e-c906f3a468de@collabora.com>
Date: Tue, 24 Sep 2024 01:24:24 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Hans Verkuil <hverkuil@...all.nl>,
 Shreeya Patel <shreeya.patel@...labora.com>, heiko@...ech.de,
 mchehab@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
 p.zabel@...gutronix.de, jose.abreu@...opsys.com, nelson.costa@...opsys.com,
 shawn.wen@...k-chips.com, nicolas.dufresne@...labora.com,
 hverkuil-cisco@...all.nl
Cc: kernel@...labora.com, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v4 4/4] media: platform: synopsys: Add support for hdmi
 input driver

On 7/23/24 11:48, Hans Verkuil wrote:
>> +static u8 edid_init_data_340M[] = {
> This should be under #ifdef CONFIG_HDMIRX_LOAD_DEFAULT_EDID, since there is
> no point to have this if you are not using it.

No need to use #ifdef since EDID array will be compiled out at a build
time. Kernel doesn't support old compilers that can't eliminate dead code.

#ifdef makes code less readable and adds requirement to build-test all
variants with/without the #ifdef, we don't want either of these.

-- 
Best regards,
Dmitry