linux-kernel - Re: [PATCH] usb: serial: digi_acceleport: Enhance error handling by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024092321-explore-student-c2a1@gregkh>
Date: Mon, 23 Sep 2024 08:49:22 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: amin-amani <didi1364@...il.com>
Cc: johan@...nel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: serial: digi_acceleport: Enhance error handling by
 checkpatch.pl

On Mon, Sep 23, 2024 at 12:45:12AM +0330, amin-amani wrote:
> - Separated null checks for port, serial and private data.
> 
> Signed-off-by: amin-amani <didi1364@...il.com>
> ---
>  drivers/usb/serial/digi_acceleport.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)

Hint, when working on a "first patch" for cleanups like this, please
work in the drivers/staging/ portion of the kernel, as that is where
stuff like this is encouraged.  Only after getting experience in the
development process should you venture out into other areas.

Also, for drivers like this, if you do not have the hardware, and can
test your changes, it can be hard to justify taking the commit.

> diff --git a/drivers/usb/serial/digi_acceleport.c b/drivers/usb/serial/digi_acceleport.c
> index d1dea3850576..d858358f94d8 100644
> --- a/drivers/usb/serial/digi_acceleport.c
> +++ b/drivers/usb/serial/digi_acceleport.c
> @@ -1309,9 +1309,14 @@ static void digi_read_bulk_callback(struct urb *urb)
>  			__func__, status);
>  		return;
>  	}
> -	if (port->serial == NULL ||
> -		(serial_priv = usb_get_serial_data(port->serial)) == NULL) {
> -		dev_err(&port->dev, "%s: serial is bad or serial->private "
> +	if (port->serial == NULL) {
> +		dev_err(&port->dev, "%s: serial is bad,"
> +			" status=%d\n", __func__, status);
> +		return;
> +	}
> +	serial_priv = usb_get_serial_data(port->serial);
> +	if (serial_priv == NULL) {
> +		dev_err(&port->dev, "%s:serial->private "

Also, what does this really provide?  Is it more helpful to you to see 2
different strings for this error?  Have you hit this before, and if so,
we should fix the root problem here instead, right?

thanks,

greg k-h