linux-kernel - Re: [PATCH v9 6/6] mtd: spi-nor: add support for Macronix Octal flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97134efb-398d-4c21-a915-87a5b4f1b29a@linaro.org>
Date: Mon, 23 Sep 2024 07:53:56 +0100
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: AlvinZhou <alvinzhou.tw@...il.com>, linux-mtd@...ts.infradead.org,
 linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
 pratyush@...nel.org, mwalle@...nel.org, miquel.raynal@...tlin.com,
 richard@....at, vigneshr@...com, broonie@...nel.org
Cc: chengminglin@...c.com.tw, leoyu@...c.com.tw,
 AlvinZhou <alvinzhou@...c.com.tw>, JaimeLiao <jaimeliao@...c.com.tw>,
 Bough Chen <haibo.chen@....com>
Subject: Re: [PATCH v9 6/6] mtd: spi-nor: add support for Macronix Octal flash

Hi, Alvin,

I quickly skimmed over the previous 5 patches and they are looking fine.

I don't get this patch however.

On 7/18/24 4:46 AM, AlvinZhou wrote:
> From: AlvinZhou <alvinzhou@...c.com.tw>
> 
> Adding Manufacture ID 0xC2 in last of ID table because of
> Octal Flash need manufacturer fixup for enabling/disabling
> Octal DTR mode.
> 
> Signed-off-by: JaimeLiao <jaimeliao@...c.com.tw>
> Signed-off-by: AlvinZhou <alvinzhou@...c.com.tw>
> ---
>  drivers/mtd/spi-nor/macronix.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index f039819a5252..1a8ccebdfe0e 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -200,7 +200,9 @@ static const struct flash_info macronix_nor_parts[] = {
>  		.name = "mx25l3255e",
>  		.size = SZ_4M,
>  		.no_sfdp_flags = SECT_4K,
> -	}
> +	},
> +	/* Need the manufacturer fixups, Keep this last */
> +	{ .id = SNOR_ID(0xc2) }
>  };
>  

Could you please elaborate why you need just the manufacturer id here? I
would have expected to see a specific flash entry instead.

Thanks,
ta