linux-kernel - RE: [PATCH] mmc: sdhci-esdhc-imx: enable quirks SDHCI_QUIRK_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB9496E0E11D5A6BB81BF122DA906F2@DU0PR04MB9496.eurprd04.prod.outlook.com>
Date: Mon, 23 Sep 2024 06:59:13 +0000
From: Bough Chen <haibo.chen@....com>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>, "adrian.hunter@...el.com"
	<adrian.hunter@...el.com>, "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>
CC: "shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>,
	"festevam@...il.com" <festevam@...il.com>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "linux-mmc@...r.kernel.org"
	<linux-mmc@...r.kernel.org>, dl-S32 <S32@....com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Peng Fan <peng.fan@....com>
Subject: RE: [PATCH] mmc: sdhci-esdhc-imx: enable quirks SDHCI_QUIRK_NO_LED

> -----Original Message-----
> From: Peng Fan (OSS) <peng.fan@....nxp.com>
> Sent: 2024年9月23日 14:20
> To: Bough Chen <haibo.chen@....com>; adrian.hunter@...el.com;
> ulf.hansson@...aro.org
> Cc: shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> festevam@...il.com; imx@...ts.linux.dev; linux-mmc@...r.kernel.org; dl-S32
> <S32@....com>; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; Peng Fan <peng.fan@....com>
> Subject: [PATCH] mmc: sdhci-esdhc-imx: enable quirks SDHCI_QUIRK_NO_LED
> 
> From: Peng Fan <peng.fan@....com>
> 
> Enable SDHCI_QUIRK_NO_LED for i.MX7ULP, i.MX8MM, i.MX8QXP and
> i.MXRT1050. Even there is LCTL register bit, there is no IOMUX PAD for it. So
> there is no sense to enable LED for SDHCI for these SoCs.
> 
Reasonable.

Reviewed-by: Haibo Chen <haibo.chen@....com>

Regards
Haibo Chen
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 8f0bc6dca2b0..ef3a44f2dff1 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -238,6 +238,7 @@ struct esdhc_platform_data {
> 
>  struct esdhc_soc_data {
>  	u32 flags;
> +	u32 quirks;
>  };
> 
>  static const struct esdhc_soc_data esdhc_imx25_data = { @@ -309,10 +310,12
> @@ static struct esdhc_soc_data usdhc_imx7ulp_data = {
>  			| ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
>  			| ESDHC_FLAG_PMQOS | ESDHC_FLAG_HS400
>  			| ESDHC_FLAG_STATE_LOST_IN_LPMODE,
> +	.quirks = SDHCI_QUIRK_NO_LED,
>  };
>  static struct esdhc_soc_data usdhc_imxrt1050_data = {
>  	.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
>  			| ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200,
> +	.quirks = SDHCI_QUIRK_NO_LED,
>  };
> 
>  static struct esdhc_soc_data usdhc_imx8qxp_data = { @@ -321,6 +324,7 @@
> static struct esdhc_soc_data usdhc_imx8qxp_data = {
>  			| ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES
>  			| ESDHC_FLAG_STATE_LOST_IN_LPMODE
>  			| ESDHC_FLAG_CLK_RATE_LOST_IN_PM_RUNTIME,
> +	.quirks = SDHCI_QUIRK_NO_LED,
>  };
> 
>  static struct esdhc_soc_data usdhc_imx8mm_data = { @@ -328,6 +332,7 @@
> static struct esdhc_soc_data usdhc_imx8mm_data = {
>  			| ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
>  			| ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES
>  			| ESDHC_FLAG_STATE_LOST_IN_LPMODE,
> +	.quirks = SDHCI_QUIRK_NO_LED,
>  };
> 
>  struct pltfm_imx_data {
> @@ -1687,6 +1692,7 @@ static int sdhci_esdhc_imx_probe(struct
> platform_device *pdev)
> 
>  	imx_data->socdata = device_get_match_data(&pdev->dev);
> 
> +	host->quirks |= imx_data->socdata->quirks;
>  	if (imx_data->socdata->flags & ESDHC_FLAG_PMQOS)
>  		cpu_latency_qos_add_request(&imx_data->pm_qos_req, 0);
> 
> --
> 2.37.1