Message-ID: <97861ebe0244454cb5e76d9c26cb6d33@ite.com.tw>
Date: Mon, 23 Sep 2024 07:25:40 +0000
From: <Hermes.Wu@....com.tw>
To: <dmitry.baryshkov@...aro.org>
CC: <treapking@...omium.org>, <a.hajda@...sung.com>, <narmstrong@...libre.com>,
        <robert.foss@...aro.org>, <Laurent.pinchart@...asonboard.com>,
        <jonas@...boo.se>, <jernej.skrabec@...il.com>, <airlied@...il.com>,
        <daniel@...ll.ch>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <Kenneth.Hung@....com.tw>
Subject: RE: [PATCH v1] drm/bridge: it6505: HDCP CTS fail on repeater items

Hi

BR,
Hermes


>-----Original Message-----
>From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> 
>Sent: Monday, September 23, 2024 2:16 PM
>To: Hermes Wu (吳佳宏) <Hermes.Wu@....com.tw>
>Cc: treapking@...omium.org; a.hajda@...sung.com; narmstrong@...libre.com; robert.foss@...aro.org; Laurent.pinchart@...asonboard.com; jonas@...boo.se; jernej.>skrabec@...il.com; airlied@...il.com; daniel@...ll.ch; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Kenneth Hung (洪家倫) <Kenneth.Hung@....com.tw>
>Subject: Re: [PATCH v1] drm/bridge: it6505: HDCP CTS fail on repeater items
>
>Hi,
>
>On Mon, Sep 23, 2024 at 05:21:41AM GMT, Hermes.Wu@....com.tw wrote:
>> Hi 
>> 
>> Sorry for the confusion caused
>
>Please don't top post. Answers should come below the original quoted
>text, not above it. Otherwise reading the email becomes really hard.
>
>> 
>> Last patches did not switch to drm-misc-nest. And I need re-create patches.
>> 
>> The HDCP patches is now on tow threads.(This one and the one include MCCS patches with cover letter)
>
>Just make sure that when you send the next iteration of the HDCP + MCSS
>patches you provide the history of the changes in the changelog (either
>in the cover letter or in the individual patches). Also please don't
>send several patches using the same vN. I'd point out the 'b4' tool, it
>can automate a lot of such topics for you.
>
I will check using of B4 tools

>> Should I keep on this thread or restart a new thread?
>
>Please always send new revisions as a new thread. Otherwise your patches
>can easily get lost.
>
>I suppose that [1] is the latest revision. Please review and implement
>the feedback that was provided to all iterations of your pachset, then
>send v3 as a separate new thread.
>
>[1] https://lore.kernel.org/dri-devel/vxs3eklfifsnaq5rn6kppegfv3plsviqaq5nvlzo3fgazwj6y7@od4atbvf5ep3/T/#u
>

A suggestion that a aux path need separate to different path, this change will before HDCP
Won't it become more complicate?

it goes like this?

Patch V1 aux
Patch V3 HDCP
Patch V3 MCCS


>> 
>> 
>> BR,
>> Hermes
>> -----Original Message-----
>> From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> 
>> Sent: Friday, September 20, 2024 11:50 PM
>> To: Pin-yen Lin <treapking@...omium.org>
>> Cc: Hermes Wu (吳佳宏) <Hermes.Wu@....com.tw>; Andrzej Hajda <a.hajda@...sung.com>; Neil Armstrong <narmstrong@...libre.com>; Robert Foss <robert.foss@...aro.org>; >Laurent Pinchart <Laurent.pinchart@...asonboard.com>; Jonas Karlman <jonas@...boo.se>; Jernej Skrabec <jernej.skrabec@...il.com>; David Airlie <airlied@...il.com>; >Daniel Vetter <daniel@...ll.ch>; open list:DRM DRIVERS <dri-devel@...ts.freedesktop.org>; open list <linux-kernel@...r.kernel.org>; Kenneth Hung (洪家倫) <Kenneth.>Hung@....com.tw>
>> Subject: Re: [PATCH v1] drm/bridge: it6505: HDCP CTS fail on repeater items
>> 
>> On Fri, Sep 20, 2024 at 01:27:54PM GMT, Pin-yen Lin wrote:
>> > On Thu, Sep 19, 2024 at 10:58 AM <Hermes.Wu@....com.tw> wrote:
>> > >
>> > > From: Hermes Wu <Hermes.Wu@....com.tw>
>> > >
>> > > Fix HDCP CTS items on UNIGRAF DPR-100.
>> > >
>> > > Signed-off-by: Hermes Wu <Hermes.Wu@....com.tw>
>> > 
>> > Reviewed-by: Pin-yen Lin <treapking@...omium.org>
>> 
>> For the sake of somebody applying the patch because it was R-B'ed
>> 
>> Nacked-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> 
>> The commit message doesn't describe what is being done and why, it
>> doesn't have Fixes tags, etc.
>> 
>> Hermes, I'm not sure what's happening on your side. I have seen several
>> revisions of this patch with minimal modifications (and being a part of
>> different series). Some of them were marked as v1 (although you've sent
>> different patches as v1), other had v2 (but no changelog, etc). Please
>> adhere to the described process of sending patches.
>> 
>> -- 
>> With best wishes
>> Dmitry

-- 
With best wishes
Dmitry

BR,
Hermes


-----Original Message-----
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> 
Sent: Monday, September 23, 2024 2:16 PM
To: Hermes Wu (吳佳宏) <Hermes.Wu@....com.tw>
Cc: treapking@...omium.org; a.hajda@...sung.com; narmstrong@...libre.com; robert.foss@...aro.org; Laurent.pinchart@...asonboard.com; jonas@...boo.se; jernej.skrabec@...il.com; airlied@...il.com; daniel@...ll.ch; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Kenneth Hung (洪家倫) <Kenneth.Hung@....com.tw>
Subject: Re: [PATCH v1] drm/bridge: it6505: HDCP CTS fail on repeater items

Hi,

On Mon, Sep 23, 2024 at 05:21:41AM GMT, Hermes.Wu@....com.tw wrote:
> Hi
> 
> Sorry for the confusion caused

Please don't top post. Answers should come below the original quoted text, not above it. Otherwise reading the email becomes really hard.

> 
> Last patches did not switch to drm-misc-nest. And I need re-create patches.
> 
> The HDCP patches is now on tow threads.(This one and the one include 
> MCCS patches with cover letter)

Just make sure that when you send the next iteration of the HDCP + MCSS patches you provide the history of the changes in the changelog (either in the cover letter or in the individual patches). Also please don't send several patches using the same vN. I'd point out the 'b4' tool, it can automate a lot of such topics for you.

> Should I keep on this thread or restart a new thread?

Please always send new revisions as a new thread. Otherwise your patches can easily get lost.

I suppose that [1] is the latest revision. Please review and implement the feedback that was provided to all iterations of your pachset, then send v3 as a separate new thread.

[1] https://lore.kernel.org/dri-devel/vxs3eklfifsnaq5rn6kppegfv3plsviqaq5nvlzo3fgazwj6y7@od4atbvf5ep3/T/#u

> 
> 
> BR,
> Hermes
> -----Original Message-----
> From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> Sent: Friday, September 20, 2024 11:50 PM
> To: Pin-yen Lin <treapking@...omium.org>
> Cc: Hermes Wu (吳佳宏) <Hermes.Wu@....com.tw>; Andrzej Hajda 
> <a.hajda@...sung.com>; Neil Armstrong <narmstrong@...libre.com>; 
> Robert Foss <robert.foss@...aro.org>; Laurent Pinchart 
> <Laurent.pinchart@...asonboard.com>; Jonas Karlman <jonas@...boo.se>; 
> Jernej Skrabec <jernej.skrabec@...il.com>; David Airlie 
> <airlied@...il.com>; Daniel Vetter <daniel@...ll.ch>; open list:DRM 
> DRIVERS <dri-devel@...ts.freedesktop.org>; open list 
> <linux-kernel@...r.kernel.org>; Kenneth Hung (洪家倫) 
> <Kenneth.Hung@....com.tw>
> Subject: Re: [PATCH v1] drm/bridge: it6505: HDCP CTS fail on repeater 
> items
> 
> On Fri, Sep 20, 2024 at 01:27:54PM GMT, Pin-yen Lin wrote:
> > On Thu, Sep 19, 2024 at 10:58 AM <Hermes.Wu@....com.tw> wrote:
> > >
> > > From: Hermes Wu <Hermes.Wu@....com.tw>
> > >
> > > Fix HDCP CTS items on UNIGRAF DPR-100.
> > >
> > > Signed-off-by: Hermes Wu <Hermes.Wu@....com.tw>
> > 
> > Reviewed-by: Pin-yen Lin <treapking@...omium.org>
> 
> For the sake of somebody applying the patch because it was R-B'ed
> 
> Nacked-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> 
> The commit message doesn't describe what is being done and why, it 
> doesn't have Fixes tags, etc.
> 
> Hermes, I'm not sure what's happening on your side. I have seen 
> several revisions of this patch with minimal modifications (and being 
> a part of different series). Some of them were marked as v1 (although 
> you've sent different patches as v1), other had v2 (but no changelog, 
> etc). Please adhere to the described process of sending patches.
> 
> --
> With best wishes
> Dmitry

--
With best wishes
Dmitry

Powered by blists - more mailing lists