linux-kernel - Re: [PATCH v1] media: atomisp: Fix typos in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvEmt92VqqiIqJtG@smile.fi.intel.com>
Date: Mon, 23 Sep 2024 11:28:39 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc: Yu Jiaoliang <yujiaoliang@...o.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Hans Verkuil <hverkuil-cisco@...all.nl>,
	Kieran Bingham <kieran.bingham@...asonboard.com>,
	Jonathan Bergh <bergh.jonathan@...il.com>,
	Kate Hsuan <hpa@...hat.com>,
	Dipendra Khadka <kdipendra88@...il.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev, opensource.kernel@...o.com
Subject: Re: [PATCH v1] media: atomisp: Fix typos in comment

On Mon, Sep 23, 2024 at 07:44:51AM +0200, Philipp Hortmann wrote:
> On 9/23/24 5:30 AM, Yu Jiaoliang wrote:

...

> Please make your "Subject" line more unique. Consider that we may end up
> with having dozen of commits like yours, all of them referring to different
> removals and all without the necessary information to tell what they differ
> in (except the driver/subsystem). So it would help if you add the changed
> file or function to make it more unique.

For _this_ driver the Subject is good enough, no need to change.
We all know that
1) AtomISP is in staging;
2) AtomISP is unique driver in the entire kernel.

> Please improve your patch description. Better omit what you are changing as
> this can be seen in the change itself. Do focus on why this patch makes the
> code better. Your sentence is fine. Just remove what you change.
> 
> If you send in a second version of this patch please use a change history.
> Description from Dan under:
> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

The above is a good advice, thanks.

-- 
With Best Regards,
Andy Shevchenko