linux-kernel - Re: [PATCH] Fix dereferencing freed memory 'fw'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEKBCKOHEynh1CLDyY8uibUXt5XhU6yGDRKAswfeQhVxGVAdEg@mail.gmail.com>
Date: Mon, 23 Sep 2024 14:30:38 +0545
From: Dipendra Khadka <kdipendra88@...il.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: gregkh@...uxfoundation.org, linux-usb@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix dereferencing freed memory 'fw'

Hi Heikki,

On Mon, 23 Sept 2024 at 14:20, Heikki Krogerus
<heikki.krogerus@...ux.intel.com> wrote:
>
> On Sun, Sep 22, 2024 at 10:52:11AM +0000, Dipendra Khadka wrote:
> > smatch reported dereferencing freed memory as below:
> > '''
> > drivers/usb/typec/tipd/core.c:1196 tps6598x_apply_patch() error: dereferencing freed memory 'fw'
> > '''
>
> This is only my opinion, but I don't like those '''single triple
> quotes''' in commit messages - they are just confusing. You don't need
> to use any kind of quotation marks in cases like this IMO.
>

Thanks for the feedback. I will send v2.

> thanks,
>
> --
> heikki

Best Regards,
Dipendra Khadka