linux-kernel - Re: [PATCH] pinctrl: check devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZYnwbpqSLrxaOZ-0rbbQq7XHjznnCqOx1Pk=8kPiYL9w@mail.gmail.com>
Date: Mon, 23 Sep 2024 11:08:40 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Ma Ke <make24@...as.ac.cn>
Cc: marcan@...can.st, sven@...npeter.dev, alyssa@...enzweig.io, maz@...nel.org, 
	joey.gouly@....com, stan@...ellium.com, asahi@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] pinctrl: check devm_kasprintf() returned value

On Thu, Sep 5, 2024 at 4:09 AM Ma Ke <make24@...as.ac.cn> wrote:

> devm_kasprintf() can return a NULL pointer on failure but this returned
> value is not checked. Fix this lack and check the returned value.
>
> Found by code review.
>
> Cc: stable@...r.kernel.org
> Fixes: a0f160ffcb83 ("pinctrl: add pinctrl/GPIO driver for Apple SoCs")
> Signed-off-by: Ma Ke <make24@...as.ac.cn>

Good catch!

Patch applied for fixes.

Yours,
Linus Walleij