linux-kernel - Re: [PATCH v1 1/1] pinctrl: nomadik: Use string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYSPGsQt_FQDurtwmyaLtB3=gaay-hLN2QdOj25e3sK8A@mail.gmail.com>
Date: Mon, 23 Sep 2024 11:11:12 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Théo Lebrun <theo.lebrun@...tlin.com>, 
	linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] pinctrl: nomadik: Use string_choices API instead
 of ternary operator

On Thu, Sep 5, 2024 at 2:56 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> On Mon, Aug 26, 2024 at 12:57:23PM +0300, Andy Shevchenko wrote:

> > Use modern string_choices API instead of manually determining the
> > output using ternary operator.
>
> Linus, do you have any comment on this?
>
> I had sent two patches of similar changes (different drivers, thoug),
> one got applied and this is not. Anything should I do about it?

Sorry for late reply :(

I thought it looks weird to replace just one string choice
in the middle of everything and it will be confusing for readers?
They will be "but what is this now, this looks weird".

Yours,
Linus Walleij