linux-kernel - Re: [PATCH v4 4/6] i2c: npcm: Modify the client address assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACD3sJbD4TuhDwazBwcc4FR2yK40LV=D-mk6VAKwNvxqAHNGLw@mail.gmail.com>
Date: Mon, 23 Sep 2024 09:59:31 +0800
From: Tyrone Ting <warp5tw@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com, 
	venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com, 
	andi.shyti@...nel.org, wsa@...nel.org, rand.sec96@...il.com, 
	wsa+renesas@...g-engineering.com, tali.perry@...oton.com, 
	Avi.Fishman@...oton.com, tomer.maimon@...oton.com, KWLIU@...oton.com, 
	JJLIU0@...oton.com, kfting@...oton.com, openbmc@...ts.ozlabs.org, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/6] i2c: npcm: Modify the client address assignment

Hi Andy:

Thank you for your feedback.

Andy Shevchenko <andriy.shevchenko@...ux.intel.com> 於 2024年9月20日 週五 下午10:33寫道：
>
> On Fri, Sep 20, 2024 at 06:18:18PM +0800, warp5tw@...il.com wrote:
> > From: Tyrone Ting <kfting@...oton.com>
> >
> > From: Tyrone Ting <kfting@...oton.com>
>
> It seems all your mails have an issue.
>

Acked in the previous email.

> > Store the client address earlier since it might get called in
> > the i2c_recover_bus logic flow at the early stage of the func()
> > npcm_i2c_master_xfer.
>
> You got my comment really wrong.
>
> func() in my example was to refer to _a_ function mentioned in the text.
> And IIRC I even posted the example, like: i2c_recover_bus().
>

So the commit message in next patch set would be like:
Store the client address earlier since it might get called in
the i2c_recover_bus() logic flow at the early stage of
npcm_i2c_master_xfer().

The code comment would be like:
Previously, the address was stored w/o left-shift by one bit and
with that shift in the following call to npcm_i2c_master_start_xmit().

Since there are cases that the i2c_recover_bus() gets called at the
early stage of npcm_i2c_master_xfer(), the address is
stored with the shift and used in the i2c_recover_bus call().


> --
> With Best Regards,
> Andy Shevchenko
>
>

Have a nice day.

Regards,
Tyrone