linux-kernel - Failed to load firmware error in radeon gpu driver code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <DM5PR1501MB1992D1D5EAF3C093BBBCB2D4F86F2@DM5PR1501MB1992.namprd15.prod.outlook.com>
Date: Mon, 23 Sep 2024 10:24:01 +0000
From: Vijay K Puliyala <vpuliyal@...ibm.com>
To: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Failed to load firmware error in radeon gpu driver code. 

We get Failed to load firmware error in radeon gpu driver code. This is compiler warning being treating as an error. I fixed it was by adding below diff.

error log :"radeon_cp: Failed to load firmware "%s"\n", fw_name);

diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
index 0b1e19345f43..170404be09ae 100644
--- a/drivers/gpu/drm/radeon/r100.c
+++ b/drivers/gpu/drm/radeon/r100.c
@@ -1059,7 +1059,11 @@ static int r100_cp_init_microcode(struct radeon_device *rdev)

        err = request_firmware(&rdev->me_fw, fw_name, rdev->dev);
        if (err) {
-               pr_err("radeon_cp: Failed to load firmware \"%s\"\n", fw_name);
+               if (fw_name) {
+                       pr_err("radeon_cp: Failed to load firmware \"%s\"\n", fw_name);
+               } else {
+                       pr_err("radeon_cp: Failed to load firmware (null)\n");  
+               }
        } else if (rdev->me_fw->size % 8) {
                pr_err("radeon_cp: Bogus length %zu in firmware \"%s\"\n",
                       rdev->me_fw->size, fw_name);

Thanks
Vijay Kumar