linux-kernel - Re: [PATCH] sched_ext: Provide a sysfs enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240923104548.GA308802@pauld.westford.csb>
Date: Mon, 23 Sep 2024 12:45:48 +0200
From: Phil Auld <pauld@...hat.com>
To: Tejun Heo <tj@...nel.org>
Cc: andrea.righi@...ux.dev, David Vernet <void@...ifault.com>,
	Giovanni Gherdovich <giovanni.gherdovich@...e.com>,
	Kleber Sacilotto de Souza <kleber.souza@...onical.com>,
	Marcelo Henrique Cerri <marcelo.cerri@...onical.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched_ext: Provide a sysfs enable_seq counter


Hi Tejun,

On Sun, Sep 22, 2024 at 11:21:02AM -1000 Tejun Heo wrote:
> Hello, Andrea.
> 
> On Sat, Sep 21, 2024 at 09:39:21PM +0200, andrea.righi@...ux.dev wrote:
> >  static struct attribute *scx_global_attrs[] = {
> >  	&scx_attr_state.attr,
> >  	&scx_attr_switch_all.attr,
> >  	&scx_attr_nr_rejected.attr,
> >  	&scx_attr_hotplug_seq.attr,
> > +	&scx_attr_enable_seq.attr,
> >  	NULL,
> >  };
> 
> Can you put this in scx_sched_attrs instead as it probably would make sense
> to track this per-scheduler in the future when we support stacked
> schedulers.

It's not a per scheduler counter, though. It's global. We want to know
that a (any) scx scheduler has been loaded at some time in the past. It's
really only interesting when 0 or > 0. The actual non-zero number and which
scheduler(s) don't matter that much.

And it needs to persist when the scheduler is unloaded (I didn't look but
I uspect the per scheduler attrs come and go?).


Cheers,
Phil

> 
> Thanks.
> 
> -- 
> tejun
> 

--