linux-kernel - Re: [PATCH v3 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f1a7746-8c06-417a-8bd9-495fdb1daa93@oss.nxp.com>
Date: Mon, 23 Sep 2024 13:57:42 +0300
From: Andrei Stefanescu <andrei.stefanescu@....nxp.com>
To: Amit Singh Tomar <amitsinght@...vell.com>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chester Lin <chester62515@...il.com>,
 Matthias Brugger <mbrugger@...e.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>
Cc: linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 NXP S32 Linux Team <s32@....com>
Subject: Re: [PATCH v3 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs
 support

Hi,

>> +#define SIUL2_PGPDO(N)        (((N) ^ 1) * 2)
>> +#define S32G2_SIUL2_NUM        2
>> +#define S32G2_PADS_DTS_TAG_LEN    (7)
> nit: Parentheses are not required here, please remove it.

Thank you for the review! I will remove the parentheses
from "S32G2_PADS_DTS_TAG_LEN" in v4.

Best regards,
Andrei