linux-kernel - Fwd: [PATCH net] net: ethernet: marvell: octeontx2: nic: Add error pointer check in otx2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAEKBCKONZ5z80P72yPpFnO1s3i_U_OW3Xd=HFOkB647dOk0JoA@mail.gmail.com>
Date: Mon, 23 Sep 2024 16:54:03 +0545
From: Dipendra Khadka <kdipendra88@...il.com>
To: linux-kernel@...r.kernel.org
Subject: Fwd: [PATCH net] net: ethernet: marvell: octeontx2: nic: Add error
 pointer check in otx2_common.c

---------- Forwarded message ---------
From: Dipendra Khadka <kdipendra88@...il.com>
Date: Mon, 23 Sept 2024 at 16:51
Subject: [PATCH net] net: ethernet: marvell: octeontx2: nic: Add error
pointer check in otx2_common.c
To: <sgoutham@...vell.com>, <gakula@...vell.com>,
<sbhatta@...vell.com>, <hkelam@...vell.com>, <davem@...emloft.net>,
<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>
Cc: Dipendra Khadka <kdipendra88@...il.com>, <netdev@...r.kernel.org>,
<cc=linux-kernel@...r.kernel.org>


Add error pointer check after calling otx2_mbox_get_rsp().

Signed-off-by: Dipendra Khadka <kdipendra88@...il.com>
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
index 87d5776e3b88..6e5f1b2e8c52 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
@@ -1838,6 +1838,11 @@ u16 otx2_get_max_mtu(struct otx2_nic *pfvf)
                rsp = (struct nix_hw_info *)
                       otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);

+               if (IS_ERR(rsp)) {
+                       mutex_unlock(&pfvf->mbox.lock);
+                       return PTR_ERR(rsp);
+               }
+
                /* HW counts VLAN insertion bytes (8 for double tag)
                 * irrespective of whether SQE is requesting to insert VLAN
                 * in the packet or not. Hence these 8 bytes have to be
--
2.43.0