linux-kernel - Re: [PATCH] LoongArch: vDSO: Tune the chacha20 implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvFji_xpV0tWxZIn@zx2c4.com>
Date: Mon, 23 Sep 2024 14:48:11 +0200
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Xi Ruoyao <xry111@...111.site>
Cc: Huacai Chen <chenhuacai@...nel.org>, WANG Xuerui <kernel@...0n.name>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	linux-crypto@...r.kernel.org, loongarch@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Jinyang He <hejinyang@...ngson.cn>,
	Tiezhu Yang <yangtiezhu@...ngson.cn>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] LoongArch: vDSO: Tune the chacha20 implementation

On Mon, Sep 23, 2024 at 04:06:41PM +0800, Xi Ruoyao wrote:
> On Mon, 2024-09-23 at 15:15 +0800, Huacai Chen wrote:
> > > +#define line3          state12, state13, state14, state15
> > > +
> > > +#define        line1_perm      state5, state6, state7, state4
> > > +#define        line2_perm      state10, state11, state8, state9
> > > +#define        line3_perm      state15, state12, state13, state14
> > > +
> > > +#define        copy            copy0, copy1, copy2, copy3
> > The indentation here is strange, it seems some of them are spaces and
> > some of them are tabs.
> 
> Oops indeed.  The tabs after "#define" should be a space instead.
> 
> Jason: can you edit it for me or do you want a new revision of the patch

I've fixed it in tree.

Jason