linux-kernel - Re: [syzbot] [hfs?] KMSAN: uninit-value in hfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_E58DB7922A5DF0DDAB19394FA78D84A5FC07@qq.com>
Date: Mon, 23 Sep 2024 22:05:17 +0800
From: Edward Adam Davis <eadavis@...com>
To: syzbot+18dd03a3fcf0ffe27da0@...kaller.appspotmail.com
Cc: linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [hfs?] KMSAN: uninit-value in hfs_iget

When the read data is insufficient to fill the rec, use 0 to fill it

#syz test

diff --git a/fs/hfs/bfind.c b/fs/hfs/bfind.c
index ef9498a6e88a..f0292b76e3d4 100644
--- a/fs/hfs/bfind.c
+++ b/fs/hfs/bfind.c
@@ -168,6 +168,8 @@ int hfs_brec_read(struct hfs_find_data *fd, void *rec, int rec_len)
 	if (fd->entrylength > rec_len)
 		return -EINVAL;
 	hfs_bnode_read(fd->bnode, rec, fd->entryoffset, fd->entrylength);
+	if (rec_len > fd->entrylength)
+		memset(rec + fd->entrylength, 0, rec_len - fd->entrylength);
 	return 0;
 }