linux-kernel - Re: [PATCH v7 02/24] x86/resctrl: Add ABMC feature in the command line options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2daaa7b-f4b9-4cf2-9cba-2cadd6f09ab6@amd.com>
Date: Mon, 23 Sep 2024 09:21:57 -0500
From: "Moger, Babu" <babu.moger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, corbet@....net,
 fenghua.yu@...el.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Cc: x86@...nel.org, hpa@...or.com, paulmck@...nel.org, rdunlap@...radead.org,
 tj@...nel.org, peterz@...radead.org, yanjiewtw@...il.com,
 kim.phillips@....com, lukas.bulwahn@...il.com, seanjc@...gle.com,
 jmattson@...gle.com, leitao@...ian.org, jpoimboe@...nel.org,
 rick.p.edgecombe@...el.com, kirill.shutemov@...ux.intel.com,
 jithu.joseph@...el.com, kai.huang@...el.com, kan.liang@...ux.intel.com,
 daniel.sneddon@...ux.intel.com, pbonzini@...hat.com, sandipan.das@....com,
 ilpo.jarvinen@...ux.intel.com, peternewman@...gle.com,
 maciej.wieczor-retman@...el.com, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, eranian@...gle.com, james.morse@....com
Subject: Re: [PATCH v7 02/24] x86/resctrl: Add ABMC feature in the command
 line options

Hi Reinette,

On 9/19/24 11:00, Reinette Chatre wrote:
> Hi Babu,
> 
> On 9/4/24 3:21 PM, Babu Moger wrote:
>> Add the command line option to enable or disable the new resctrl feature
>> ABMC (Assignable Bandwidth Monitoring Counters).
> 
> This does not reflect the fs and arch separation that this version highlights
> since ABMC is not a resctrl feature.
> 
> This can get confusing and I think this interface is indeed for the
> architecture where hardware features are enabled/disabled (highlighted
> by how the parameter is connected to the X86_FEATURE_ flag) ... so
> perhaps something like:
> 
> 	Add the command line option to enable or disable exposing
> 	the ABMC (Assignable Bandwidth Monitoring Counters) hardware
> 	feature to resctrl.

Sure.

> 
> Patch looks good to me.

-- 
Thanks
Babu Moger