| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202409232343.7o1tQrIx-lkp@intel.com>
Date: Tue, 24 Sep 2024 00:08:03 +0800
From: kernel test robot <lkp@...el.com>
To: Alice Ryhl <aliceryhl@...gle.com>, Matthew Wilcox <willy@...radead.org>,
Jonathan Corbet <corbet@....net>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
linux-fsdevel@...r.kernel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
Alice Ryhl <aliceryhl@...gle.com>
Subject: Re: [PATCH] xarray: rename xa_lock/xa_unlock to xa_enter/xa_leave
Hi Alice,
kernel test robot noticed the following build errors:
[auto build test ERROR on 98f7e32f20d28ec452afb208f9cffc08448a2652]
url: https://github.com/intel-lab-lkp/linux/commits/Alice-Ryhl/xarray-rename-xa_lock-xa_unlock-to-xa_enter-xa_leave/20240923-184045
base: 98f7e32f20d28ec452afb208f9cffc08448a2652
patch link: https://lore.kernel.org/r/20240923-xa_enter_leave-v1-1-6ff365e8520a%40google.com
patch subject: [PATCH] xarray: rename xa_lock/xa_unlock to xa_enter/xa_leave
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20240923/202409232343.7o1tQrIx-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240923/202409232343.7o1tQrIx-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409232343.7o1tQrIx-lkp@intel.com/
All errors (new ones prefixed by >>):
>> lib/idr.c:453:2: error: call to undeclared function 'xas_leave_irqsave'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
453 | xas_unlock_irqrestore(&xas, flags);
| ^
include/linux/xarray.h:1453:43: note: expanded from macro 'xas_unlock_irqrestore'
1453 | #define xas_unlock_irqrestore(xas, flags) xas_leave_irqsave(xas, flags)
| ^
lib/idr.c:521:2: error: call to undeclared function 'xas_leave_irqsave'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
521 | xas_unlock_irqrestore(&xas, flags);
| ^
include/linux/xarray.h:1453:43: note: expanded from macro 'xas_unlock_irqrestore'
1453 | #define xas_unlock_irqrestore(xas, flags) xas_leave_irqsave(xas, flags)
| ^
lib/idr.c:553:2: error: call to undeclared function 'xas_leave_irqsave'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
553 | xas_unlock_irqrestore(&xas, flags);
| ^
include/linux/xarray.h:1453:43: note: expanded from macro 'xas_unlock_irqrestore'
1453 | #define xas_unlock_irqrestore(xas, flags) xas_leave_irqsave(xas, flags)
| ^
3 errors generated.
--
>> lib/xarray.c:2256:2: error: call to undeclared function 'xas_leave_irqsave'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2256 | xas_unlock_irqrestore(&xas, flags);
| ^
include/linux/xarray.h:1453:43: note: expanded from macro 'xas_unlock_irqrestore'
1453 | #define xas_unlock_irqrestore(xas, flags) xas_leave_irqsave(xas, flags)
| ^
1 error generated.
--
>> mm/page-writeback.c:2801:2: error: call to undeclared function 'xa_leave_irqsave'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2801 | xa_unlock_irqrestore(&mapping->i_pages, flags);
| ^
include/linux/xarray.h:567:41: note: expanded from macro 'xa_unlock_irqrestore'
567 | #define xa_unlock_irqrestore(xa, flags) xa_leave_irqsave(xa, flags)
| ^
mm/page-writeback.c:3100:3: error: call to undeclared function 'xa_leave_irqsave'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
3100 | xa_unlock_irqrestore(&mapping->i_pages, flags);
| ^
include/linux/xarray.h:567:41: note: expanded from macro 'xa_unlock_irqrestore'
567 | #define xa_unlock_irqrestore(xa, flags) xa_leave_irqsave(xa, flags)
| ^
>> mm/page-writeback.c:3155:3: error: call to undeclared function 'xas_leave_irqsave'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
3155 | xas_unlock_irqrestore(&xas, flags);
| ^
include/linux/xarray.h:1453:43: note: expanded from macro 'xas_unlock_irqrestore'
1453 | #define xas_unlock_irqrestore(xas, flags) xas_leave_irqsave(xas, flags)
| ^
3 errors generated.
vim +/xas_leave_irqsave +453 lib/idr.c
5806f07cd2c329 Jeff Mahoney 2006-06-26 307
56083ab17e0075 Randy Dunlap 2010-10-26 308 /**
56083ab17e0075 Randy Dunlap 2010-10-26 309 * DOC: IDA description
72dba584b695d8 Tejun Heo 2007-06-14 310 *
0a835c4f090af2 Matthew Wilcox 2016-12-20 311 * The IDA is an ID allocator which does not provide the ability to
0a835c4f090af2 Matthew Wilcox 2016-12-20 312 * associate an ID with a pointer. As such, it only needs to store one
0a835c4f090af2 Matthew Wilcox 2016-12-20 313 * bit per ID, and so is more space efficient than an IDR. To use an IDA,
0a835c4f090af2 Matthew Wilcox 2016-12-20 314 * define it using DEFINE_IDA() (or embed a &struct ida in a data structure,
0a835c4f090af2 Matthew Wilcox 2016-12-20 315 * then initialise it using ida_init()). To allocate a new ID, call
5ade60dda43c89 Matthew Wilcox 2018-03-20 316 * ida_alloc(), ida_alloc_min(), ida_alloc_max() or ida_alloc_range().
5ade60dda43c89 Matthew Wilcox 2018-03-20 317 * To free an ID, call ida_free().
72dba584b695d8 Tejun Heo 2007-06-14 318 *
b03f8e43c92618 Matthew Wilcox 2018-06-18 319 * ida_destroy() can be used to dispose of an IDA without needing to
b03f8e43c92618 Matthew Wilcox 2018-06-18 320 * free the individual IDs in it. You can use ida_is_empty() to find
b03f8e43c92618 Matthew Wilcox 2018-06-18 321 * out whether the IDA has any IDs currently allocated.
0a835c4f090af2 Matthew Wilcox 2016-12-20 322 *
f32f004cddf86d Matthew Wilcox 2018-07-04 323 * The IDA handles its own locking. It is safe to call any of the IDA
f32f004cddf86d Matthew Wilcox 2018-07-04 324 * functions without synchronisation in your code.
f32f004cddf86d Matthew Wilcox 2018-07-04 325 *
0a835c4f090af2 Matthew Wilcox 2016-12-20 326 * IDs are currently limited to the range [0-INT_MAX]. If this is an awkward
0a835c4f090af2 Matthew Wilcox 2016-12-20 327 * limitation, it should be quite straightforward to raise the maximum.
72dba584b695d8 Tejun Heo 2007-06-14 328 */
72dba584b695d8 Tejun Heo 2007-06-14 329
d37cacc5adace7 Matthew Wilcox 2016-12-17 330 /*
d37cacc5adace7 Matthew Wilcox 2016-12-17 331 * Developer's notes:
d37cacc5adace7 Matthew Wilcox 2016-12-17 332 *
f32f004cddf86d Matthew Wilcox 2018-07-04 333 * The IDA uses the functionality provided by the XArray to store bitmaps in
f32f004cddf86d Matthew Wilcox 2018-07-04 334 * each entry. The XA_FREE_MARK is only cleared when all bits in the bitmap
f32f004cddf86d Matthew Wilcox 2018-07-04 335 * have been set.
d37cacc5adace7 Matthew Wilcox 2016-12-17 336 *
f32f004cddf86d Matthew Wilcox 2018-07-04 337 * I considered telling the XArray that each slot is an order-10 node
f32f004cddf86d Matthew Wilcox 2018-07-04 338 * and indexing by bit number, but the XArray can't allow a single multi-index
f32f004cddf86d Matthew Wilcox 2018-07-04 339 * entry in the head, which would significantly increase memory consumption
f32f004cddf86d Matthew Wilcox 2018-07-04 340 * for the IDA. So instead we divide the index by the number of bits in the
f32f004cddf86d Matthew Wilcox 2018-07-04 341 * leaf bitmap before doing a radix tree lookup.
d37cacc5adace7 Matthew Wilcox 2016-12-17 342 *
d37cacc5adace7 Matthew Wilcox 2016-12-17 343 * As an optimisation, if there are only a few low bits set in any given
3159f943aafdba Matthew Wilcox 2017-11-03 344 * leaf, instead of allocating a 128-byte bitmap, we store the bits
f32f004cddf86d Matthew Wilcox 2018-07-04 345 * as a value entry. Value entries never have the XA_FREE_MARK cleared
f32f004cddf86d Matthew Wilcox 2018-07-04 346 * because we can always convert them into a bitmap entry.
f32f004cddf86d Matthew Wilcox 2018-07-04 347 *
f32f004cddf86d Matthew Wilcox 2018-07-04 348 * It would be possible to optimise further; once we've run out of a
f32f004cddf86d Matthew Wilcox 2018-07-04 349 * single 128-byte bitmap, we currently switch to a 576-byte node, put
f32f004cddf86d Matthew Wilcox 2018-07-04 350 * the 128-byte bitmap in the first entry and then start allocating extra
f32f004cddf86d Matthew Wilcox 2018-07-04 351 * 128-byte entries. We could instead use the 512 bytes of the node's
f32f004cddf86d Matthew Wilcox 2018-07-04 352 * data as a bitmap before moving to that scheme. I do not believe this
f32f004cddf86d Matthew Wilcox 2018-07-04 353 * is a worthwhile optimisation; Rasmus Villemoes surveyed the current
f32f004cddf86d Matthew Wilcox 2018-07-04 354 * users of the IDA and almost none of them use more than 1024 entries.
f32f004cddf86d Matthew Wilcox 2018-07-04 355 * Those that do use more than the 8192 IDs that the 512 bytes would
f32f004cddf86d Matthew Wilcox 2018-07-04 356 * provide.
f32f004cddf86d Matthew Wilcox 2018-07-04 357 *
f32f004cddf86d Matthew Wilcox 2018-07-04 358 * The IDA always uses a lock to alloc/free. If we add a 'test_bit'
d37cacc5adace7 Matthew Wilcox 2016-12-17 359 * equivalent, it will still need locking. Going to RCU lookup would require
d37cacc5adace7 Matthew Wilcox 2016-12-17 360 * using RCU to free bitmaps, and that's not trivial without embedding an
d37cacc5adace7 Matthew Wilcox 2016-12-17 361 * RCU head in the bitmap, which adds a 2-pointer overhead to each 128-byte
d37cacc5adace7 Matthew Wilcox 2016-12-17 362 * bitmap, which is excessive.
d37cacc5adace7 Matthew Wilcox 2016-12-17 363 */
d37cacc5adace7 Matthew Wilcox 2016-12-17 364
f32f004cddf86d Matthew Wilcox 2018-07-04 365 /**
f32f004cddf86d Matthew Wilcox 2018-07-04 366 * ida_alloc_range() - Allocate an unused ID.
f32f004cddf86d Matthew Wilcox 2018-07-04 367 * @ida: IDA handle.
f32f004cddf86d Matthew Wilcox 2018-07-04 368 * @min: Lowest ID to allocate.
f32f004cddf86d Matthew Wilcox 2018-07-04 369 * @max: Highest ID to allocate.
f32f004cddf86d Matthew Wilcox 2018-07-04 370 * @gfp: Memory allocation flags.
f32f004cddf86d Matthew Wilcox 2018-07-04 371 *
f32f004cddf86d Matthew Wilcox 2018-07-04 372 * Allocate an ID between @min and @max, inclusive. The allocated ID will
f32f004cddf86d Matthew Wilcox 2018-07-04 373 * not exceed %INT_MAX, even if @max is larger.
f32f004cddf86d Matthew Wilcox 2018-07-04 374 *
3b6742618ed921 Stephen Boyd 2020-10-15 375 * Context: Any context. It is safe to call this function without
3b6742618ed921 Stephen Boyd 2020-10-15 376 * locking in your code.
f32f004cddf86d Matthew Wilcox 2018-07-04 377 * Return: The allocated ID, or %-ENOMEM if memory could not be allocated,
f32f004cddf86d Matthew Wilcox 2018-07-04 378 * or %-ENOSPC if there are no free IDs.
f32f004cddf86d Matthew Wilcox 2018-07-04 379 */
f32f004cddf86d Matthew Wilcox 2018-07-04 380 int ida_alloc_range(struct ida *ida, unsigned int min, unsigned int max,
f32f004cddf86d Matthew Wilcox 2018-07-04 381 gfp_t gfp)
72dba584b695d8 Tejun Heo 2007-06-14 382 {
f32f004cddf86d Matthew Wilcox 2018-07-04 383 XA_STATE(xas, &ida->xa, min / IDA_BITMAP_BITS);
f32f004cddf86d Matthew Wilcox 2018-07-04 384 unsigned bit = min % IDA_BITMAP_BITS;
f32f004cddf86d Matthew Wilcox 2018-07-04 385 unsigned long flags;
f32f004cddf86d Matthew Wilcox 2018-07-04 386 struct ida_bitmap *bitmap, *alloc = NULL;
f32f004cddf86d Matthew Wilcox 2018-07-04 387
f32f004cddf86d Matthew Wilcox 2018-07-04 388 if ((int)min < 0)
f32f004cddf86d Matthew Wilcox 2018-07-04 389 return -ENOSPC;
f32f004cddf86d Matthew Wilcox 2018-07-04 390
f32f004cddf86d Matthew Wilcox 2018-07-04 391 if ((int)max < 0)
f32f004cddf86d Matthew Wilcox 2018-07-04 392 max = INT_MAX;
f32f004cddf86d Matthew Wilcox 2018-07-04 393
f32f004cddf86d Matthew Wilcox 2018-07-04 394 retry:
f32f004cddf86d Matthew Wilcox 2018-07-04 395 xas_lock_irqsave(&xas, flags);
f32f004cddf86d Matthew Wilcox 2018-07-04 396 next:
f32f004cddf86d Matthew Wilcox 2018-07-04 397 bitmap = xas_find_marked(&xas, max / IDA_BITMAP_BITS, XA_FREE_MARK);
f32f004cddf86d Matthew Wilcox 2018-07-04 398 if (xas.xa_index > min / IDA_BITMAP_BITS)
0a835c4f090af2 Matthew Wilcox 2016-12-20 399 bit = 0;
f32f004cddf86d Matthew Wilcox 2018-07-04 400 if (xas.xa_index * IDA_BITMAP_BITS + bit > max)
f32f004cddf86d Matthew Wilcox 2018-07-04 401 goto nospc;
f32f004cddf86d Matthew Wilcox 2018-07-04 402
3159f943aafdba Matthew Wilcox 2017-11-03 403 if (xa_is_value(bitmap)) {
3159f943aafdba Matthew Wilcox 2017-11-03 404 unsigned long tmp = xa_to_value(bitmap);
f32f004cddf86d Matthew Wilcox 2018-07-04 405
f32f004cddf86d Matthew Wilcox 2018-07-04 406 if (bit < BITS_PER_XA_VALUE) {
f32f004cddf86d Matthew Wilcox 2018-07-04 407 bit = find_next_zero_bit(&tmp, BITS_PER_XA_VALUE, bit);
f32f004cddf86d Matthew Wilcox 2018-07-04 408 if (xas.xa_index * IDA_BITMAP_BITS + bit > max)
f32f004cddf86d Matthew Wilcox 2018-07-04 409 goto nospc;
f32f004cddf86d Matthew Wilcox 2018-07-04 410 if (bit < BITS_PER_XA_VALUE) {
f32f004cddf86d Matthew Wilcox 2018-07-04 411 tmp |= 1UL << bit;
f32f004cddf86d Matthew Wilcox 2018-07-04 412 xas_store(&xas, xa_mk_value(tmp));
f32f004cddf86d Matthew Wilcox 2018-07-04 413 goto out;
d37cacc5adace7 Matthew Wilcox 2016-12-17 414 }
f32f004cddf86d Matthew Wilcox 2018-07-04 415 }
f32f004cddf86d Matthew Wilcox 2018-07-04 416 bitmap = alloc;
f32f004cddf86d Matthew Wilcox 2018-07-04 417 if (!bitmap)
f32f004cddf86d Matthew Wilcox 2018-07-04 418 bitmap = kzalloc(sizeof(*bitmap), GFP_NOWAIT);
d37cacc5adace7 Matthew Wilcox 2016-12-17 419 if (!bitmap)
f32f004cddf86d Matthew Wilcox 2018-07-04 420 goto alloc;
3159f943aafdba Matthew Wilcox 2017-11-03 421 bitmap->bitmap[0] = tmp;
f32f004cddf86d Matthew Wilcox 2018-07-04 422 xas_store(&xas, bitmap);
f32f004cddf86d Matthew Wilcox 2018-07-04 423 if (xas_error(&xas)) {
f32f004cddf86d Matthew Wilcox 2018-07-04 424 bitmap->bitmap[0] = 0;
f32f004cddf86d Matthew Wilcox 2018-07-04 425 goto out;
f32f004cddf86d Matthew Wilcox 2018-07-04 426 }
d37cacc5adace7 Matthew Wilcox 2016-12-17 427 }
d37cacc5adace7 Matthew Wilcox 2016-12-17 428
0a835c4f090af2 Matthew Wilcox 2016-12-20 429 if (bitmap) {
f32f004cddf86d Matthew Wilcox 2018-07-04 430 bit = find_next_zero_bit(bitmap->bitmap, IDA_BITMAP_BITS, bit);
f32f004cddf86d Matthew Wilcox 2018-07-04 431 if (xas.xa_index * IDA_BITMAP_BITS + bit > max)
f32f004cddf86d Matthew Wilcox 2018-07-04 432 goto nospc;
0a835c4f090af2 Matthew Wilcox 2016-12-20 433 if (bit == IDA_BITMAP_BITS)
f32f004cddf86d Matthew Wilcox 2018-07-04 434 goto next;
72dba584b695d8 Tejun Heo 2007-06-14 435
0a835c4f090af2 Matthew Wilcox 2016-12-20 436 __set_bit(bit, bitmap->bitmap);
0a835c4f090af2 Matthew Wilcox 2016-12-20 437 if (bitmap_full(bitmap->bitmap, IDA_BITMAP_BITS))
f32f004cddf86d Matthew Wilcox 2018-07-04 438 xas_clear_mark(&xas, XA_FREE_MARK);
0a835c4f090af2 Matthew Wilcox 2016-12-20 439 } else {
3159f943aafdba Matthew Wilcox 2017-11-03 440 if (bit < BITS_PER_XA_VALUE) {
3159f943aafdba Matthew Wilcox 2017-11-03 441 bitmap = xa_mk_value(1UL << bit);
3159f943aafdba Matthew Wilcox 2017-11-03 442 } else {
f32f004cddf86d Matthew Wilcox 2018-07-04 443 bitmap = alloc;
72dba584b695d8 Tejun Heo 2007-06-14 444 if (!bitmap)
f32f004cddf86d Matthew Wilcox 2018-07-04 445 bitmap = kzalloc(sizeof(*bitmap), GFP_NOWAIT);
f32f004cddf86d Matthew Wilcox 2018-07-04 446 if (!bitmap)
f32f004cddf86d Matthew Wilcox 2018-07-04 447 goto alloc;
0a835c4f090af2 Matthew Wilcox 2016-12-20 448 __set_bit(bit, bitmap->bitmap);
3159f943aafdba Matthew Wilcox 2017-11-03 449 }
f32f004cddf86d Matthew Wilcox 2018-07-04 450 xas_store(&xas, bitmap);
72dba584b695d8 Tejun Heo 2007-06-14 451 }
f32f004cddf86d Matthew Wilcox 2018-07-04 452 out:
f32f004cddf86d Matthew Wilcox 2018-07-04 @453 xas_unlock_irqrestore(&xas, flags);
f32f004cddf86d Matthew Wilcox 2018-07-04 454 if (xas_nomem(&xas, gfp)) {
f32f004cddf86d Matthew Wilcox 2018-07-04 455 xas.xa_index = min / IDA_BITMAP_BITS;
f32f004cddf86d Matthew Wilcox 2018-07-04 456 bit = min % IDA_BITMAP_BITS;
f32f004cddf86d Matthew Wilcox 2018-07-04 457 goto retry;
72dba584b695d8 Tejun Heo 2007-06-14 458 }
f32f004cddf86d Matthew Wilcox 2018-07-04 459 if (bitmap != alloc)
f32f004cddf86d Matthew Wilcox 2018-07-04 460 kfree(alloc);
f32f004cddf86d Matthew Wilcox 2018-07-04 461 if (xas_error(&xas))
f32f004cddf86d Matthew Wilcox 2018-07-04 462 return xas_error(&xas);
f32f004cddf86d Matthew Wilcox 2018-07-04 463 return xas.xa_index * IDA_BITMAP_BITS + bit;
f32f004cddf86d Matthew Wilcox 2018-07-04 464 alloc:
f32f004cddf86d Matthew Wilcox 2018-07-04 465 xas_unlock_irqrestore(&xas, flags);
f32f004cddf86d Matthew Wilcox 2018-07-04 466 alloc = kzalloc(sizeof(*bitmap), gfp);
f32f004cddf86d Matthew Wilcox 2018-07-04 467 if (!alloc)
f32f004cddf86d Matthew Wilcox 2018-07-04 468 return -ENOMEM;
f32f004cddf86d Matthew Wilcox 2018-07-04 469 xas_set(&xas, min / IDA_BITMAP_BITS);
f32f004cddf86d Matthew Wilcox 2018-07-04 470 bit = min % IDA_BITMAP_BITS;
f32f004cddf86d Matthew Wilcox 2018-07-04 471 goto retry;
f32f004cddf86d Matthew Wilcox 2018-07-04 472 nospc:
f32f004cddf86d Matthew Wilcox 2018-07-04 473 xas_unlock_irqrestore(&xas, flags);
a219b856a2b993 Matthew Wilcox (Oracle 2020-04-02 474) kfree(alloc);
f32f004cddf86d Matthew Wilcox 2018-07-04 475 return -ENOSPC;
0a835c4f090af2 Matthew Wilcox 2016-12-20 476 }
f32f004cddf86d Matthew Wilcox 2018-07-04 477 EXPORT_SYMBOL(ida_alloc_range);
72dba584b695d8 Tejun Heo 2007-06-14 478
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists