linux-kernel - Re: [PATCH v1 01/17] mm: factor out large folio handling from folio_order() into folio_large

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABzRoyb3zNKPKCSWzdK8uy81pzf8MB_-4-kCCAoTeoPHD5tExA@mail.gmail.com>
Date: Mon, 23 Sep 2024 12:44:59 +0800
From: Lance Yang <ioworker0@...il.com>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, cgroups@...r.kernel.org, 
	x86@...nel.org, linux-fsdevel@...r.kernel.org, 
	Andrew Morton <akpm@...ux-foundation.org>, "Matthew Wilcox (Oracle)" <willy@...radead.org>, 
	Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>, 
	Johannes Weiner <hannes@...xchg.org>, Michal Koutný <mkoutny@...e.com>, 
	Jonathan Corbet <corbet@....net>, Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, 
	Dave Hansen <dave.hansen@...ux.intel.com>
Subject: Re: [PATCH v1 01/17] mm: factor out large folio handling from
 folio_order() into folio_large_order()

On Fri, Aug 30, 2024 at 12:57 AM David Hildenbrand <david@...hat.com> wrote:
>
> Let's factor it out into a simple helper function. This helper will
> also come in handy when working with code where we know that our
> folio is large.
>
> Signed-off-by: David Hildenbrand <david@...hat.com>

LGTM. Feel feel to add:

Reviewed-by: Lance Yang <ioworker0@...il.com>

Thanks,
Lance

> ---
>  include/linux/mm.h | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index b31d4bdd65ad5..3c6270f87bdc3 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -1071,6 +1071,11 @@ int vma_is_stack_for_current(struct vm_area_struct *vma);
>  struct mmu_gather;
>  struct inode;
>
> +static inline unsigned int folio_large_order(const struct folio *folio)
> +{
> +       return folio->_flags_1 & 0xff;
> +}
> +
>  /*
>   * compound_order() can be called without holding a reference, which means
>   * that niceties like page_folio() don't work.  These callers should be
> @@ -1084,7 +1089,7 @@ static inline unsigned int compound_order(struct page *page)
>
>         if (!test_bit(PG_head, &folio->flags))
>                 return 0;
> -       return folio->_flags_1 & 0xff;
> +       return folio_large_order(folio);
>  }
>
>  /**
> @@ -1100,7 +1105,7 @@ static inline unsigned int folio_order(const struct folio *folio)
>  {
>         if (!folio_test_large(folio))
>                 return 0;
> -       return folio->_flags_1 & 0xff;
> +       return folio_large_order(folio);
>  }
>
>  #include <linux/huge_mm.h>
> @@ -2035,7 +2040,7 @@ static inline long folio_nr_pages(const struct folio *folio)
>  #ifdef CONFIG_64BIT
>         return folio->_folio_nr_pages;
>  #else
> -       return 1L << (folio->_flags_1 & 0xff);
> +       return 1L << folio_large_order(folio);
>  #endif
>  }
>
> @@ -2060,7 +2065,7 @@ static inline unsigned long compound_nr(struct page *page)
>  #ifdef CONFIG_64BIT
>         return folio->_folio_nr_pages;
>  #else
> -       return 1L << (folio->_flags_1 & 0xff);
> +       return 1L << folio_large_order(folio);
>  #endif
>  }
>
> --
> 2.46.0
>
>