linux-kernel - Re: [PATCH] ipe: Add missing terminator to list of unit tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e824b125-0ab0-4e1f-9411-abbc1984c124@linux.microsoft.com>
Date: Mon, 23 Sep 2024 10:40:45 -0700
From: Fan Wu <wufan@...ux.microsoft.com>
To: Paul Moore <paul@...l-moore.com>, Guenter Roeck <linux@...ck-us.net>
Cc: "Serge E . Hallyn" <serge@...lyn.com>,
 linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org,
 Deven Bowers <deven.desai@...ux.microsoft.com>
Subject: Re: [PATCH] ipe: Add missing terminator to list of unit tests



On 9/22/2024 5:27 PM, Paul Moore wrote:
> On Sun, Sep 22, 2024 at 10:52 AM Guenter Roeck <linux@...ck-us.net> wrote:
>>
>> Add missing terminator to list of unit tests to avoid random crashes seen
>> when running the test.
>>
>> Fixes: 10ca05a76065 ("ipe: kunit test for parser")
>> Cc: Deven Bowers <deven.desai@...ux.microsoft.com>
>> Cc: Paul Moore <paul@...l-moore.com>
>> Cc: Fan Wu <wufan@...ux.microsoft.com>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>> ---
>>   security/ipe/policy_tests.c | 1 +
>>   1 file changed, 1 insertion(+)
> 
> I'm guessing Fan doesn't have his tree setup yet, but if I can get an
> ACK from Fan I can send this up via the LSM tree for the next
> v6.12-rcX release.
> 
>> diff --git a/security/ipe/policy_tests.c b/security/ipe/policy_tests.c
>> index 89521f6b9994..5f1654deeb04 100644
>> --- a/security/ipe/policy_tests.c
>> +++ b/security/ipe/policy_tests.c
>> @@ -286,6 +286,7 @@ static void ipe_parser_widestring_test(struct kunit *test)
>>   static struct kunit_case ipe_parser_test_cases[] = {
>>          KUNIT_CASE_PARAM(ipe_parser_unsigned_test, ipe_policies_gen_params),
>>          KUNIT_CASE(ipe_parser_widestring_test),
>> +       { }
>>   };
>>
>>   static struct kunit_suite ipe_parser_test_suite = {
> 

Yes this looks good to me.

Acked-by: Fan Wu <wufan@...ux.microsoft.com>