linux-kernel - Re: arch/powerpc/include/asm/switch_to.h:53:2: error: call to '__compiletime_assert_256' declared with 'error' attribute: BUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240923183914.GA671157@thelio-3990X>
Date: Mon, 23 Sep 2024 11:39:14 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: kernel test robot <lkp@...el.com>
Cc: Michael Ellerman <mpe@...erman.id.au>, llvm@...ts.linux.dev,
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: arch/powerpc/include/asm/switch_to.h:53:2: error: call to
 '__compiletime_assert_256' declared with 'error' attribute: BUILD_BUG failed

On Mon, Sep 23, 2024 at 07:34:48AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   de5cb0dcb74c294ec527eddfe5094acfdb21ff21
> commit: c2e5d70cf05b48bfbd5b6625bbd0ec3052cecd5d powerpc/83xx: Fix build failure with FPU=n
> date:   7 months ago
> config: powerpc-randconfig-001-20240923 (https://download.01.org/0day-ci/archive/20240923/202409230705.hFpB3jMt-lkp@intel.com/config)
> compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 8663a75fa2f31299ab8d1d90288d9df92aadee88)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240923/202409230705.hFpB3jMt-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202409230705.hFpB3jMt-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
...
>    In file included from drivers/cpufreq/pmac32-cpufreq.c:38:
> >> arch/powerpc/include/asm/switch_to.h:53:2: error: call to '__compiletime_assert_256' declared with 'error' attribute: BUILD_BUG failed
>       53 |         BUILD_BUG();
>          |         ^
>    include/linux/build_bug.h:59:21: note: expanded from macro 'BUILD_BUG'
>       59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed")
>          |                     ^
>    include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG'
>       39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>          |                                     ^
>    include/linux/compiler_types.h:435:2: note: expanded from macro 'compiletime_assert'
>      435 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>          |         ^
>    include/linux/compiler_types.h:423:2: note: expanded from macro '_compiletime_assert'
>      423 |         __compiletime_assert(condition, msg, prefix, suffix)
>          |         ^
>    include/linux/compiler_types.h:416:4: note: expanded from macro '__compiletime_assert'
>      416 |                         prefix ## suffix();                             \
>          |                         ^
>    <scratch space>:106:1: note: expanded from here
>      106 | __compiletime_assert_256
>          | ^
>    1 warning and 1 error generated.

Does not appear to be clang related but it seems like
drivers/cpufreq/pmac32-cpufreq.c needs the same fixup?

Cheers,
Nathan

diff --git a/drivers/cpufreq/pmac32-cpufreq.c b/drivers/cpufreq/pmac32-cpufreq.c
index 6c9f0888a2a7..25e84b7d3728 100644
--- a/drivers/cpufreq/pmac32-cpufreq.c
+++ b/drivers/cpufreq/pmac32-cpufreq.c
@@ -260,7 +260,8 @@ static int pmu_set_cpu_speed(int low_speed)
 	local_irq_save(flags);
 
 	/* Giveup the FPU & vec */
-	enable_kernel_fp();
+	if (IS_ENABLED(CONFIG_PPC_FPU))
+		enable_kernel_fp();
 
 #ifdef CONFIG_ALTIVEC
 	if (cpu_has_feature(CPU_FTR_ALTIVEC))