linux-kernel - Re: [PATCH v1] media: atomisp: Fix typos in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25ec1b00-02fc-4ecb-853c-de9c8a12f9fc@gmail.com>
Date: Mon, 23 Sep 2024 07:44:51 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Yu Jiaoliang <yujiaoliang@...o.com>, Hans de Goede <hdegoede@...hat.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Andy Shevchenko <andy@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Hans Verkuil <hverkuil-cisco@...all.nl>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Jonathan Bergh <bergh.jonathan@...il.com>, Kate Hsuan <hpa@...hat.com>,
 Dipendra Khadka <kdipendra88@...il.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] media: atomisp: Fix typos in comment

On 9/23/24 5:30 AM, Yu Jiaoliang wrote:
> Corrected typos:
> componnet->component,
> cofiguration->configuration,
> doubtfull->doubtful,
> consisit->consist,
> coppied->copied.
> 
> These changes fix the typos in the comment,
> without affecting the functionality.
> 
> Signed-off-by: Yu Jiaoliang <yujiaoliang@...o.com>

Hi Jiaoliang,

Please make your "Subject" line more unique. Consider that we may end up 
with having dozen of commits like yours, all of them referring to 
different removals and all without the necessary information to tell 
what they differ in (except the driver/subsystem). So it would help if 
you add the changed file or function to make it more unique.

Please improve your patch description. Better omit what you are changing 
as this can be seen in the change itself. Do focus on why this patch 
makes the code better. Your sentence is fine. Just remove what you change.

If you send in a second version of this patch please use a change 
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Thanks

Bye Philipp