[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240923-private-grower-af6a7c1fca09@spud>
Date: Mon, 23 Sep 2024 22:23:39 +0100
From: Conor Dooley <conor@...nel.org>
To: Chanh Nguyen <chanh@...amperecomputing.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Guenter Roeck <linux@...ck-us.net>,
Peter Yin <peteryin.openbmc@...il.com>,
Noah Wang <noahwang.wang@...look.com>, Marek Vasut <marex@...x.de>,
Fabio Estevam <festevam@...il.com>, Lukas Wunner <lukas@...ner.de>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
Phong Vo <phong@...amperecomputing.com>,
Thang Nguyen <thang@...amperecomputing.com>,
Quan Nguyen <quan@...amperecomputing.com>,
Khanh Pham <khpham@...erecomputing.com>,
Open Source Submission <patches@...erecomputing.com>
Subject: Re: [PATCH v2] dt-bindings: trivial-devices: add onnn,adt7462
On Mon, Sep 23, 2024 at 09:38:00AM +0000, Chanh Nguyen wrote:
> The adt7462 supports monitoring and controlling up to
> four PWM Fan drive outputs and eight TACH inputs measures.
> The adt7462 supports reading a single on chip temperature
> sensor and three remote temperature sensors. There are up
> to 13 voltage monitoring inputs.
>
> Add device tree bindings for the adt7462 device.
>
> Signed-off-by: Chanh Nguyen <chanh@...amperecomputing.com>
> ---
> Change in v2:
> - Add onnn,adt7462 to the list of trivial devices [Guenter]
Is this really a trivial device? If it monitors and controls fans, how
come those do not need to be represented in the devicetree? How is it
possible to tell the difference between monitoring 1 and 4 fans without
the extra detail?
Curious,
Conor.
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 0108d7507215..15f89d7ecf73 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -311,6 +311,8 @@ properties:
> - nuvoton,w83773g
> # OKI ML86V7667 video decoder
> - oki,ml86v7667
> + # ON Semiconductor ADT7462 Temperature, Voltage Monitor and Fan Controller
> + - onnn,adt7462
> # 48-Lane, 12-Port PCI Express Gen 2 (5.0 GT/s) Switch
> - plx,pex8648
> # Pulsedlight LIDAR range-finding sensor
> --
> 2.43.0
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists