linux-kernel - Re: [patch v2 3/3] riscv: dts: starfive: add framework dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ce90574a-6be8-4415-9943-b559d274cf04@kernel.org>
Date: Tue, 24 Sep 2024 20:40:32 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: 曹珊珊 <sandie.cao@...pcomputing.io>
Cc: Conor Dooley <conor@...nel.org>, Emil Renner Berthing <kernel@...il.dk>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Heiko Stuebner <heiko.stuebner@...rry.de>,
 Neil Armstrong <neil.armstrong@...aro.org>, rafal@...ecki.pl,
 Linus Walleij <linus.walleij@...aro.org>,
 Michael Zhu <michael.zhu@...rfivetech.com>,
 Drew Fustini <drew@...gleboard.org>, linux-riscv@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, dhs@...me.work,
 ams@...me.work, gregkh@...uxfoundation.org, yuning.liang@...pcomputing.io,
 huiming.qiu@...pcomputing.io
Subject: Re: [patch v2 3/3] riscv: dts: starfive: add framework dts

On 24/09/2024 10:52, 曹珊珊 wrote:
> Hi Krzysztof,
> 
> Thanks for your time.
> 
> A: jh7110-common.dtsi is also used by other boards. Likes: milkv-mars, 
> pine64-star64. So I can only disable them in jh7110-framework.dts. 
> Or I need to create a new common.dtsi. 
> 
> Q: Why PCIE0 is enabled in the DTSI in the first place? The same questions
> about MACs.
> 
> Regards,
> Sandie
> 
> On 24/09/2024 10:06, Sandie Cao wrote:
>> Add framework dts to support RISC-V Framework Laptop 13 Mainboard.
>>  
>> Signed-off-by: Sandie Cao <sandie.cao@...pcomputing.io>
>> ---
>>   arch/riscv/boot/dts/starfive/Makefile         |  1 +
>>   .../boot/dts/starfive/jh7110-framework.dts    | 34 +++++++++++++++++++
>>   2 files changed, 35 insertions(+)
>>   create mode 100644 arch/riscv/boot/dts/starfive/jh7110-framework.dts
> 
> Your threading is entirely broken making applying process more difficult.

So I am talking with myself?

...

>> +        status = "disabled";
>> +};
>> +
>> +&pcie0 {
>> +        status = "disabled";
> 
> Why PCIE0 is enabled in the DTSI in the first place? The same questions
> about MACs.
> 
> Best regards,
> Krzysztof

And sending myself regards?

Sorry, no clue what's going on here.

Best regards,
Krzysztof