linux-kernel - Re: [PATCH] btrfs: Remove unused page_to_{inode,fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEg-Je_Lv7x7u8Az49xr04T=S5tk3XAmtoCYL+97wKVkftNOpQ@mail.gmail.com>
Date: Mon, 23 Sep 2024 23:55:33 -0400
From: Neal Gompa <neal@...pa.dev>
To: Youling Tang <youling.tang@...ux.dev>
Cc: Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>, 
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Youling Tang <tangyouling@...inos.cn>
Subject: Re: [PATCH] btrfs: Remove unused page_to_{inode,fs_info} macros

On Mon, Sep 23, 2024 at 10:32 PM Youling Tang <youling.tang@...ux.dev> wrote:
>
> From: Youling Tang <tangyouling@...inos.cn>
>
> This macro is no longer used after the "btrfs: Cleaned up folio->page
> conversion" series patch [1] was applied, so remove it.
>
> [1]: https://patchwork.kernel.org/project/linux-btrfs/cover/20240828182908.3735344-1-lizetao1@huawei.com/
>
> Signed-off-by: Youling Tang <tangyouling@...inos.cn>
> ---
>  fs/btrfs/fs.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/fs/btrfs/fs.h b/fs/btrfs/fs.h
> index 79f64e383edd..82169cbd99e1 100644
> --- a/fs/btrfs/fs.h
> +++ b/fs/btrfs/fs.h
> @@ -876,12 +876,9 @@ struct btrfs_fs_info {
>  #endif
>  };
>
> -#define page_to_inode(_page)   (BTRFS_I(_Generic((_page),                      \
> -                                         struct page *: (_page))->mapping->host))
>  #define folio_to_inode(_folio) (BTRFS_I(_Generic((_folio),                     \
>                                           struct folio *: (_folio))->mapping->host))
>
> -#define page_to_fs_info(_page)  (page_to_inode(_page)->root->fs_info)
>  #define folio_to_fs_info(_folio) (folio_to_inode(_folio)->root->fs_info)
>
>  #define inode_to_fs_info(_inode) (BTRFS_I(_Generic((_inode),                   \
> --
> 2.34.1
>
>

Patch looks good to me.

Reviewed-by: Neal Gompa <neal@...pa.dev>


-- 
真実はいつも一つ！/ Always, there's only one truth!