[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240924184719.686727-1-sj@kernel.org>
Date: Tue, 24 Sep 2024 11:47:18 -0700
From: SeongJae Park <sj@...nel.org>
To: David Hunter <david.hunter.linux@...il.com>
Cc: SeongJae Park <sj@...nel.org>,
Shuah Khan <shuah@...nel.org>,
Allison Henderson <allison.henderson@...cle.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
damon@...ts.linux.dev,
linux-mm@...ck.org,
linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org,
netdev@...r.kernel.org,
linux-rdma@...r.kernel.org,
rds-devel@....oracle.com,
javier.carrasco.cruz@...il.com
Subject: Re: [PATCH v1 1/1] selftests: set executable bit
Hi David,
On Tue, 24 Sep 2024 13:54:57 -0400 David Hunter <david.hunter.linux@...il.com> wrote:
> Turn on the executable bit for the following script files. These scripts
> are set to TEST_PROGS in their respective Makefiles, but currently, when
> these tests are run, a warning occurs:
>
> # Warning: <file> is not executable
Thank you so much for finding this issue and sending this nice fix!
>
> Signed-off-by: David Hunter <david.hunter.linux@...il.com>
> ---
> tools/testing/selftests/damon/damon_nr_regions.py | 0
> tools/testing/selftests/damon/damos_apply_interval.py | 0
> tools/testing/selftests/damon/damos_quota.py | 0
> tools/testing/selftests/damon/damos_quota_goal.py | 0
> tools/testing/selftests/damon/damos_tried_regions.py | 0
> tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh | 0
> .../damon/debugfs_target_ids_read_before_terminate_race.sh | 0
> .../selftests/damon/sysfs_update_schemes_tried_regions_hang.py | 0
> .../damon/sysfs_update_schemes_tried_regions_wss_estimation.py | 0
> tools/testing/selftests/net/rds/test.py | 0
> 10 files changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 tools/testing/selftests/damon/damon_nr_regions.py
> mode change 100644 => 100755 tools/testing/selftests/damon/damos_apply_interval.py
> mode change 100644 => 100755 tools/testing/selftests/damon/damos_quota.py
> mode change 100644 => 100755 tools/testing/selftests/damon/damos_quota_goal.py
> mode change 100644 => 100755 tools/testing/selftests/damon/damos_tried_regions.py
> mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh
> mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.sh
> mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_hang.py
> mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_wss_estimation.py
> mode change 100644 => 100755 tools/testing/selftests/net/rds/test.py
However, a very similar fix has already posted [1] and merged [2] into the
mainline. So, apparently there was a trivial race. I'm looking forward to
your next patches for DAMON, though!
[1] https://lore.kernel.org/20240827030336.7930-4-sj@kernel.org
[2] https://github.com/torvalds/linux/commit/8c211412c5dffd090eaea5ee033cd729f8e5f873
Thanks,
SJ
[...]
Powered by blists - more mailing lists