linux-kernel - Re: [PATCH] i2c: I2C_KEBA should depend on KEBA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4abb8472-5b93-4709-b37e-9f19b9fe77b7@engleder-embedded.com>
Date: Tue, 24 Sep 2024 20:32:13 +0200
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
 Gerhard Engleder <eg@...a.com>, Andi Shyti <andi.shyti@...nel.org>
Subject: Re: [PATCH] i2c: I2C_KEBA should depend on KEBA_CP500

On 24.09.24 11:34, Geert Uytterhoeven wrote:
> The KEBA I2C controller is only present on KEBA PLC devices.  Hence add
> a dependency on KEBA_CP500, to prevent asking the user about this driver
> when configuring a kernel without KEBA CP500 system FPGA support.
> 
> Fixes: c7e08c816cd2fdf8 ("i2c: keba: Add KEBA I2C controller support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>   drivers/i2c/busses/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 0ea437c76167ad2d..229b8166ccc03803 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -782,6 +782,7 @@ config I2C_JZ4780
>   config I2C_KEBA
>          tristate "KEBA I2C controller support"
>          depends on HAS_IOMEM
> +       depends on KEBA_CP500 || COMPILE_TEST

Makes sense. I will add that dependency to the next similar drivers.

Thanks!

Reviewed-by: Gerhard Engleder <eg@...a.com>