linux-kernel - Re: [PATCH v5] dt-bindings: opp: operating-points-v2-ti-cpu: Describe opp-supported-hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172720869759.222696.1265461647431110381.robh@kernel.org>
Date: Tue, 24 Sep 2024 15:11:38 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Dhruva Gole <d-gole@...com>
Cc: Stephen Boyd <sboyd@...nel.org>, devicetree@...r.kernel.org,
	Vignesh Raghavendra <vigneshr@...com>, linux-pm@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Nishanth Menon <nm@...com>, Viresh Kumar <vireshk@...nel.org>,
	linux-kernel@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
	Viresh Kumar <viresh.kumar@...aro.org>
Subject: Re: [PATCH v5] dt-bindings: opp: operating-points-v2-ti-cpu:
 Describe opp-supported-hw


On Thu, 19 Sep 2024 18:43:40 +0530, Dhruva Gole wrote:
> It seems like we missed migrating the complete information from the old
> DT binding where we had described what the opp-supported-hw is supposed
> to describe. Hence, bring back the description from the previous binding
> to the current one along with a bit more context on what the values are
> supposed to be.
> 
> Fixes: e576a9a8603f ("dt-bindings: cpufreq: Convert ti-cpufreq to json schema")
> Signed-off-by: Dhruva Gole <d-gole@...com>
> ---
> Changes in v5:
> - Fix the new lines inserted to seperate paragraphs.
> - /eg./example,/
> - Fix Odd line wrapping
> - Link to v4: https://lore.kernel.org/all/20240918173431.GA1833339-robh@kernel.org/
> 
> Changes in v4:
> - Fix dt_binding_check errors on previous revision.
> - As per Rob's suggestion, used a blank line in between description
>   and the paragraph.
> - Reworded the description a bit.
> - Link to v3: https://lore.kernel.org/all/20240917095252.1292321-1-d-gole@ti.com/
> 
> Changes in v3:
> - Use the items: and then provide description for both required items.
>   This tries to address Rob's comments on previous revision.
> - I've not use min/max Items as the 2 descriptions items implicitly
>   imply that number of bitfields needed are 2.
> - Link to v2: https://lore.kernel.org/all/20240905-b4-opp-dt-binding-fix-v2-1-1e3d2a06748d@ti.com/
> 
> Changes in v2:
> - Drop the patch where I updated Maintainers since it's already picked
>   by Viresh.
> - Add more details of how to populate the property based on device
>   documents like TRM/ datasheet.
> - Link to v1: https://lore.kernel.org/r/20240903-b4-opp-dt-binding-fix-v1-0-f7e186456d9f@ti.com
> ---
>  .../bindings/opp/operating-points-v2-ti-cpu.yaml     | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>