lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8291c6eb-750a-4ab2-8904-65d723d034dd@riseup.net>
Date: Tue, 24 Sep 2024 23:33:13 +0200
From: André Almeida <andrealmeid@...eup.net>
To: Vinicius Peixoto <vpeixoto@...amp.dev>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, ~lkcamp/patches@...ts.sr.ht,
 Rae Moar <rmoar@...gle.com>, David Gow <davidgow@...gle.com>,
 Andrew Morton <akpm@...ux-foundation.org>, kunit-dev@...glegroups.com,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 0/1] Add KUnit tests for lib/crc16.c

Hey!

On 9/23/24 01:26, Vinicius Peixoto wrote:
> Hi all,
>
> This patch was developed during a hackathon organized by LKCAMP [1],
> with the objective of writing KUnit tests, both to introduce people to
> the kernel development process and to learn about different subsystems
> (with the positive side effect of improving the kernel test coverage, of
> course).
>
> We noticed there were tests for CRC32 in lib/crc32test.c and thought it
> would be nice to have something similar for CRC16, since it seems to be
> widely used in network drivers (as well as in some ext4 code).
>
> Although this patch turned out quite big, most of the LOCs come from
> tables containing randomly-generated test data that we use to validate
> the kernel's implementation of CRC-16.
Can you share how you created the tables? Given that is impossible to 
review the table itself, at least people will be able to see how they 
got created at least.
> We would really appreciate any feedback/suggestions on how to improve
> this. Thanks! :-)
>
> Vinicius Peixoto (1):
>    lib/crc16_kunit.c: add KUnit tests for crc16
>
>   lib/Kconfig.debug |   8 +
>   lib/Makefile      |   1 +
>   lib/crc16_kunit.c | 715 ++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 724 insertions(+)
>   create mode 100644 lib/crc16_kunit.c
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ