linux-kernel - Re: [RFC PATCH v4.5] dt-bindings: mfd: Add Realtek RTL9300 switch peripherals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172722008668.561416.13765711287255233220.robh@kernel.org>
Date: Tue, 24 Sep 2024 18:21:26 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc: devicetree@...r.kernel.org, tsbogend@...ha.franken.de, lee@...nel.org, 
 linux-kernel@...r.kernel.org, krzk@...nel.org, linux-mips@...r.kernel.org, 
 conor+dt@...nel.org
Subject: Re: [RFC PATCH v4.5] dt-bindings: mfd: Add Realtek RTL9300 switch
 peripherals


On Wed, 25 Sep 2024 10:16:26 +1200, Chris Packham wrote:
> Add device tree schema for the Realtek RTL9300 switches. The RTL9300
> family is made up of the RTL9301, RTL9302B, RTL9302C and RTL9303. These
> have the same SoC differ in the Ethernet switch/SERDES arrangement.
> 
> Currently the only supported features are the syscon-reboot and i2c
> controllers. The syscon-reboot is needed to be able to reboot the board.
> The I2C controllers are slightly unusual because they each own an SCL
> pin (GPIO 8 for the first controller, GPIO 17 for the second) but have 8
> common SDA pins which can be assigned to either controller (but not
> both).
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
> 
> This is my initial attempt at addressing Krzysztof's comments from my two
> series. I expect there may still be a bit of discussion on the binding so I'm
> just sending this on it's own rather than the whole series.
> 
>  .../bindings/i2c/realtek,rtl9300-i2c.yaml     |  98 ++++++++++++++++
>  .../bindings/mfd/realtek,rtl9300-switch.yaml  | 110 ++++++++++++++++++
>  2 files changed, 208 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.yaml
>  create mode 100644 Documentation/devicetree/bindings/mfd/realtek,rtl9300-switch.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/realtek,rtl9300-switch.example.dtb: ethernet-switch@...00000: 'reboot' is a required property
	from schema $id: http://devicetree.org/schemas/mfd/realtek,rtl9300-switch.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/realtek,rtl9300-switch.example.dtb: ethernet-switch@...00000: '#address-cells', '#size-cells', 'i2c@...', 'i2c@...', 'reboot@c' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/mfd/realtek,rtl9300-switch.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/realtek,rtl9300-switch.example.dtb: reboot@c: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/power/reset/syscon-reboot.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240924221626.3290531-1-chris.packham@alliedtelesis.co.nz

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.