linux-kernel - Re: [PATCH] drm/v3d: Use v3d_perfmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5fc3e586-cc8d-4ee5-ad1a-23740d1075a1@igalia.com>
Date: Tue, 24 Sep 2024 20:27:55 -0300
From: Maíra Canal <mcanal@...lia.com>
To: Christian Gmeiner <christian.gmeiner@...il.com>,
 Melissa Wen <mwen@...lia.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: Christian Gmeiner <cgmeiner@...lia.com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/v3d: Use v3d_perfmon_find(..)

Hi Christian,

On 9/23/24 12:19, Christian Gmeiner wrote:
> From: Christian Gmeiner <cgmeiner@...lia.com>
> 
> Replace the open coded v3d_perfmon_find(..) with the real
> thing.
> 
> Signed-off-by: Christian Gmeiner <cgmeiner@...lia.com>

Thanks for your patch!

Reviewed-by: Maíra Canal <mcanal@...lia.com>

Applied to misc/kernel.git (drm-misc-next).

Best Regards,
- Maíra

> ---
>   drivers/gpu/drm/v3d/v3d_perfmon.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/v3d/v3d_perfmon.c b/drivers/gpu/drm/v3d/v3d_perfmon.c
> index cd7f1eedf17f..54a486a9b74c 100644
> --- a/drivers/gpu/drm/v3d/v3d_perfmon.c
> +++ b/drivers/gpu/drm/v3d/v3d_perfmon.c
> @@ -402,11 +402,7 @@ int v3d_perfmon_get_values_ioctl(struct drm_device *dev, void *data,
>   	if (req->pad != 0)
>   		return -EINVAL;
>   
> -	mutex_lock(&v3d_priv->perfmon.lock);
> -	perfmon = idr_find(&v3d_priv->perfmon.idr, req->id);
> -	v3d_perfmon_get(perfmon);
> -	mutex_unlock(&v3d_priv->perfmon.lock);
> -
> +	perfmon = v3d_perfmon_find(v3d_priv, req->id);
>   	if (!perfmon)
>   		return -EINVAL;
>