linux-kernel - Re: [PATCH v2 net] net: ethernet: marvell: octeontx2: nic: Add error pointer check in otx2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240924071537.GC4029621@kernel.org>
Date: Tue, 24 Sep 2024 08:15:37 +0100
From: Simon Horman <horms@...nel.org>
To: Dipendra Khadka <kdipendra88@...il.com>
Cc: sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
	hkelam@...vell.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH v2 net] net: ethernet: marvell: octeontx2: nic: Add error
 pointer check in otx2_common.c

+ Maxime Chevallier

On Mon, Sep 23, 2024 at 04:17:37PM +0000, Dipendra Khadka wrote:
> Adding error pointer check after calling otx2_mbox_get_rsp().
> 
> Fixes: ab58a416c93f ("octeontx2-pf: cn10k: Get max mtu supported from admin function")
> Signed-off-by: Dipendra Khadka <kdipendra88@...il.com>
> ---
> v2:
>  - Added Fixes: tag.
>  - Changed the return logic to follow the existing return path.
> v1: https://lore.kernel.org/all/20240923110633.3782-1-kdipendra88@gmail.com/
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 ++++
>  1 file changed, 4 insertions(+)

Hi Dipendra,

Thanks for the updates,

I agree that this addresses Maxime's changes.  I've CCed him here, please
consider CCing people who comment on earlier revisions of patches.

My only nit about this patch is that, as per mo comment on [1], I think the
prefix in the subject should be 'octeontx2-pf: '.

[1] https://lore.kernel.org/netdev/20240924071026.GB4029621@kernel.org/

> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> index 87d5776e3b88..e4bde38eebda 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> @@ -1837,6 +1837,10 @@ u16 otx2_get_max_mtu(struct otx2_nic *pfvf)
>  	if (!rc) {
>  		rsp = (struct nix_hw_info *)
>  		       otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);
> +		if (IS_ERR(rsp)) {
> +			rc = PTR_ERR(rsp);
> +			goto out;
> +		}
>  
>  		/* HW counts VLAN insertion bytes (8 for double tag)
>  		 * irrespective of whether SQE is requesting to insert VLAN

-- 
pw-bot: changes-requested