linux-kernel - Re: [PATCH 2/7] staging: vt6655: Rename variable iTDUsed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c20e4935-faca-41ef-ab66-09199b38a6d2@gmail.com>
Date: Tue, 24 Sep 2024 09:29:27 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Xingquan Liu <b1n@....io>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] staging: vt6655: Rename variable iTDUsed

On 9/23/24 2:09 PM, Xingquan Liu wrote:
> Hi,
> 
> I'm a bit confused. Should I rename struct vnt_tx_desc 
> *apCurrTD[TYPE_MAXTD];
> to curr_td?
> It looks like 'ap' means array pointer.

Hi Xingquan,

yes I think so as well.
This line shows this:
priv->apCurrTD[0] = &priv->ap_td0_rings[0];

> 
> For struct vnt_rx_desc *aRD0Ring;, where 'a' doesn't means array, should
> I rename it to rd0_ring?
> 

When the "a" does not belong to hungarian notation it can remain.

The following is just my personal opinion:
You can keep working on this driver and your patches will remain in the 
git. But I think I will propose to delete this driver. Reason is that it 
supports maximum 54MBit/s and the connection is always weak. Its form 
factor is mini PCI that is really old. I use an adapter from mini PCI to 
PCI to get it into my Desktop PC. It furthermore is not buyable anymore.

I like to focus on the hardware that is really well useable and on the 
market available:

For example:
rtl8712  (r8712u)
Backard Bell: AW-NU120

Thanks for your support.

Bye Philipp