lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <65E61995-5C32-48D4-ACB4-761EEAE7A585@linux.dev>
Date: Tue, 24 Sep 2024 15:35:37 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: david@...hat.com,
 hughd@...gle.com,
 willy@...radead.org,
 vbabka@...nel.org,
 akpm@...ux-foundation.org,
 rppt@...nel.org,
 vishal.moola@...il.com,
 peterx@...hat.com,
 ryan.roberts@....com,
 christophe.leroy2@...soprasteria.com,
 linux-kernel@...r.kernel.org,
 linux-mm@...ck.org,
 linux-arm-kernel@...ts.infradead.org,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v4 08/13] mm: copy_pte_range() use
 pte_offset_map_rw_nolock()



> On Sep 24, 2024, at 14:10, Qi Zheng <zhengqi.arch@...edance.com> wrote:
> 
> In copy_pte_range(), we may modify the src_pte entry after holding the
> src_ptl, so convert it to using pte_offset_map_rw_nolock(). Since we
> already hold the exclusive mmap_lock, and the copy_pte_range() and
> retract_page_tables() are using vma->anon_vma to be exclusive, so the PTE
> page is stable, there is no need to get pmdval and do pmd_same() check.
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

Reviewed-by: Muchun Song <muchun.song@...ux.dev>



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ