linux-kernel - Re: [PATCH] regulator: do not ignore provided init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZvJ0wgeztxijv14i@finisterre.sirena.org.uk>
Date: Tue, 24 Sep 2024 10:13:54 +0200
From: Mark Brown <broonie@...nel.org>
To: Jerome Brunet <jbrunet@...libre.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: do not ignore provided init_data

On Mon, Sep 23, 2024 at 06:50:33PM +0200, Jerome Brunet wrote:
> On Mon 23 Sep 2024 at 16:19, Mark Brown <broonie@...nel.org> wrote:

> > That probably means checking if regulator_of_get_init_node() can find
> > something and warning if that's the case.

> We could warn if both init_data and desc->of_match are set ?

> Setting desc->of_match is an indication regulator is expected to search
> DT, is'nt it ? Having both set be the indicaction of the conflict.

> Maybe the warn is enough then. Do you prefer if I keep the change of v1
> or drop it ?

Yes, that'd detect problems.  There's some older drivers that don't use
of_match but it'd cover most things quite cheaply.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)